On Sun, 31 Jul 2011 18:23:06 +1000, Andrew Harvey wrote:

> Hi,

Hello Andrew,

> I've made a debian package for the SJJB Map icons
> http://www.sjjb.co.uk/mapicons/downloads.
> At the moment, I don't think anything packaged in debian uses these
> icons, but in the future it may prove to be useful. I'm sure I've made
> some packaging mistakes so I'm open to feedback.
> For now my files are at

I took the package from mentors, as you stated later.

- as for leaflet, you should've filed an ITP, not an RFP. Please fix this :)

- "Debian OpenStreetMap Team <pkg-osm-maint@lists.alioth.debian.org>" should be
  set as the package maintainer in debian/control

- you need to add Vcs-* fields in debian/control, after you create a repository
  on vasks, and push there.

- in debian/rules, I'm not sure you need to override_dh_clean. Maybe
  listing that directory in debian/clean works (it works with files for sure,
  can't tell for directories)

- in debian/rules, get-orig-source target: to avoid harcoding the upstream
  tarball name, you can pass "--rename" to uscan. This will cause the tarball
  to be named like "foo_1.2.orig.tar.gz" -- which you already remove. You save
  a couple lines of code :)

- again get-orig-source: why are you passing --group, --user and --mode to tar
  when you repack the tarball?

Please fix these issues; I'll review the package once again.


 . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://deb.li/dapal
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

Attachment: signature.asc
Description: PGP signature

Pkg-osm-maint mailing list

Reply via email to