Hi David,

Thanks for your helpful comments, being rigorous, and getting me to
fix up my mistakes.

On Sun, Sep 25, 2011 at 5:20 AM, David Paleino <da...@debian.org> wrote:
>  $ bts retitle 641883 ITP: libjs-leaflet -- JavaScript library [..]

Done. Thanks.

> - You should add yourself to Uploaders in debian/control

Done.

> - You Build-Depend on debhelper >= 8, but debian/compat is 7. Please fix this 
> :)

Done by bumping debian/compat.

> - Vcs-* fields are for Debian packaging, not the upstream repositories. Both
>  should read something like this, when you'll push the repo to pkg-osm:
>
>    Vcs-Git: git://git.debian.org/pkg-osm/leaflet.git
>    Vcs-Browser: http://git.debian.org/?p=pkg-osm/leaflet.git

Done.

> - debian/copyright: it should be cleaner if you state a common "License: 
> BSD-2"
>  stanza with the whole text, so that you don't repeat it twice :). But it's a
>  minor problem, it's fine also this way.

Right. No worries I've cleaned it up anyway as per
http://dep.debian.net/deps/dep5/

> - why is debian/rules under GPL-2+, if the debian packaging is BSD-2 ? This is
>  a bit confusing. If you're sure you want debian/rules to be under that
>  license, please state it in debian/copyright.

I left the GPL-2+ license for debian/rules in tact because I built the
rules file based of  the GPL-2+ debian/rules from the khtmlib package.
I've updated debian/copyright to reflect this. Thanks.

My debian packaging is also BSD-2 because I thought I should keep it
the same as the license of the software I'm packaging. I believe this
is my choice, but as I don't mind if I license the packaging BSD-2 or
GPL-2+, I've included both.

>
> Other than this, the package seems fine. Please fix the above issues, and I'll
> recheck it.

Thank you.

>
> Next time, you can create a git repository on vasks, and point to that repo --
> no need to use mentors. Here's how to:
>
>  $ ssh vasks.debian.org
>  $ cd /git/pkg-osm/
>  $ ./setup-repository leaflet.git "Short description found in debian/control"

No worries, after adding my public ssh key at
https://alioth.debian.org/account/ I could login using
andrewharvey-gu...@vasks.debian.org.

I did ./setup-repository leaflet "short desc"

Although now I think I should change the package description in
debian/control to include what upstream use which is "Leaflet is a
modern JavaScript library for interactive maps on both desktop and
mobile browsers by CloudMade." I've changed that too.

I reviewed http://wiki.debian.org/Alioth/Git and
http://wiki.debian.org/PackagingWithGit, ran git-import-dsc, and then
git pushed master upstream pristine-tar and --tags to the new repo on
git.debian.org. Hopefully I've got everything right so far.

Thanks for your help so far David.

_______________________________________________
Pkg-osm-maint mailing list
Pkg-osm-maint@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-osm-maint

Reply via email to