Hi David,

On Sun, Sep 25, 2011 at 5:31 AM, David Paleino <da...@debian.org> wrote:
> - as for leaflet, you should've filed an ITP, not an RFP. Please fix this :)

Done. Thanks.

> - "Debian OpenStreetMap Team <pkg-osm-maint@lists.alioth.debian.org>" should 
> be
>  set as the package maintainer in debian/control

Done.

> - you need to add Vcs-* fields in debian/control, after you create a 
> repository
>  on vasks, and push there.

Done. But I haven't made the git repo on vasks yet. Before doing that
I think we should decide on the package name. Originally I used
sjjb-map-icons but then I used sjjbmapicons as existing package names
have '-' for some special usage. eg. -data -dbg -doc, and also
libboost-foo, python- to split up the boost, python libraries, etc.

I'm not really sure which is better sjjb-map-icons or sjjbmapicons,
but I think maybe the second due to the special use of '-' in existing
packages. What do you think? After I know what to use, I'll make it
consistent within the package and make the git repo on vasks, with all
my changes.

> - in debian/rules, I'm not sure you need to override_dh_clean. Maybe
>  listing that directory in debian/clean works (it works with files for sure,
>  can't tell for directories)

Listing the directory in debian/clean didn't work dh_clean says:
rm: cannot remove `pngall': Is a directory
dh_clean: rm -f -- pngall returned exit code 1

> - in debian/rules, get-orig-source target: to avoid harcoding the upstream
>  tarball name, you can pass "--rename" to uscan. This will cause the tarball
>  to be named like "foo_1.2.orig.tar.gz" -- which you already remove. You save
>  a couple lines of code :)

Done.

> - again get-orig-source: why are you passing --group, --user and --mode to tar
>  when you repack the tarball?

I'm not sure, but I've changed it now to avoid doing this.

> Please fix these issues; I'll review the package once again.

I can upload these changes to git.debian.org once we sort out the package name.

Thanks for you help.

_______________________________________________
Pkg-osm-maint mailing list
Pkg-osm-maint@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-osm-maint

Reply via email to