On Tue, 14 Feb 2012 09:30:17 +1100, Andrew Harvey wrote:

> Hi David,

Hello Andrew,

no need to CC me when you write to pkg-osm-maint :). Also, I'm CCing you
because I don't know whether you're subscribed or not.

> You previously sponsored the upload of the leaflet package. I've just
> updated it to release 0.3, is it possible for you to review and assuming
> all is well upload it again?
> 
> I've left the uploader to do the debian/0.3-1 tag in the alioth
> repository once it is uploaded (as well as bumping the changelog to
> unstable).

Thanks, that's very nice.

> I've also patched the upstream build to skip running tests as that
> relied on the unpackaged JSHint.
> 
> Please let me know if there is anything I could have done better.

The only thing I could argue about is: do smaller commits. "updating debian
files for 0.3-1 release" isn't very useful, and "git show" shows a bunch of
seemingly unrelated changes (apart from the common fact that they happen in
the 0.3-1 package).

It would've been easier for me (or any other sponsor, I believe) if you did
different commits, for example: "Update debian/rules for new upstream build
system" and "Patch upstream build system to avoid running tests until jshlint is
packaged" would already have been better than the single-commit :)

Usually, all non-trivial changes should be documented in debian/changelog:
remember, "debcommit" is your friend (it's a wrapper around "$vcs commit", that
takes your last d/changelog entry as the commit message). It's not mandatory to
use it, but it's nice :)

(I also usually do a "New upstream version" before anything else, right after
the merge, which just adds a new debian/changelog stanza, but that's just a
habit I have to ease diffs and reverts)

The package is nice, just the new patch is missing a DEP-3 header, but I'm
uploading it nevertheless.

Thanks for your contribution!
David

-- 
 . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://deb.li/dapal
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Pkg-osm-maint mailing list
Pkg-osm-maint@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-osm-maint

Reply via email to