This is an automated email from the git hooks/post-receive script.

xguimard-guest pushed a commit to branch master
in repository libdbd-firebird-perl.

commit 30087f205e086cab7e533f0acd361d2997d39713
Author: Xavier Guimard <x.guim...@free.fr>
Date:   Wed Apr 2 06:58:35 2014 +0200

    Remove skip-threaded patch now included upstream
---
 debian/patches/series                           |  1 -
 debian/patches/skip-threaded-events-tests.patch | 51 -------------------------
 2 files changed, 52 deletions(-)

diff --git a/debian/patches/series b/debian/patches/series
deleted file mode 100644
index cb2d726..0000000
--- a/debian/patches/series
+++ /dev/null
@@ -1 +0,0 @@
-skip-threaded-events-tests.patch
diff --git a/debian/patches/skip-threaded-events-tests.patch 
b/debian/patches/skip-threaded-events-tests.patch
deleted file mode 100644
index 6be48c5..0000000
--- a/debian/patches/skip-threaded-events-tests.patch
+++ /dev/null
@@ -1,51 +0,0 @@
-From 0e6b1a2370f605dacfd9d5b85e26384879371a11 Mon Sep 17 00:00:00 2001
-From: Damyan Ivanov <d...@debian.org>
-Date: Thu, 9 Jan 2014 13:04:12 +0000
-Subject: [PATCH] skip thread event tests under AUTOMATED_TESTING
-
-this causes failure to build in Debian (http://bugs.debian.org/732324)
-
-to trigger the crash, the test needs to be run in a loop, under
-a very heavy system load. Here's a oneliner:
-
- ( export AUTOMATED_TESTING=1 ; C=0; while perl -Iblib/arch:blib/lib 
t/embed-80-event-ithreads.t; do C=$(( $C + 1 )); echo $C ; done )
-
-I inspected some coredumps, and the segfault is at different place
-every time, suggesting memory/stack corruption. Some of the backtraces
-had traces from firebird shutdown sequence (presumably caused by the
-embedded disconnect code) and some had tried to emit perl errors about
-attempts to free unreferenced scalars and such.
-
-My best guess for the core reason is the tricky concept of shutting
-down FB engine (just look for 'shutdown' at tracker.firebirdsql.org),
-which I guess sometimes doesn't play nicely with perl threads.
-
-If my guess is right, it is not 100% safe to establish/close
-connections via FirebirdEmbedded from perl threads.
-
-Of course, the root cause may as well be in perl (though with the same
-conclusion).
-
-I added a TODO note to enable the tests again when FB3 comes out. If
-it proves stable, we may enable the tests depending on FB version.
----
- t/80-event-ithreads.t | 3 +++
- 1 file changed, 3 insertions(+)
-
-diff --git a/t/80-event-ithreads.t b/t/80-event-ithreads.t
-index d4c764f..82f474d 100644
---- a/t/80-event-ithreads.t
-+++ b/t/80-event-ithreads.t
-@@ -96,6 +96,9 @@ SKIP: {
-     skip "this $^O perl $] is not configured to support iThreads", $how_many 
if (!$Config{useithreads} || $] < 5.008);
-     skip "known problems under MSWin32 ActivePerl's iThreads", $how_many if 
$Config{osname} eq 'MSWin32';
-     skip "Perl version is older than 5.8.8", $how_many if $^V and $^V lt 
v5.8.8;
-+    # TODO: try enabling this when firebird 3 is released stable
-+    skip "thread tests unstable under load", $how_many
-+        if $ENV{AUTOMATED_TESTING};
-     eval { require threads };
-     skip "unable to use threads;", $how_many if $@;
- 
--- 
-1.8.5.2
-

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/pkg-perl/packages/libdbd-firebird-perl.git

_______________________________________________
Pkg-perl-cvs-commits mailing list
Pkg-perl-cvs-commits@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-perl-cvs-commits

Reply via email to