This is an automated email from the git hooks/post-receive script. jame-guest pushed a commit to annotated tag 0.22 in repository libnet-citadel-perl.
commit a5e6d17d7b3616a0435afc77465ecb04319ab1f6 Author: Robert James Clay <j...@rocasa.us> Date: Mon Aug 22 18:36:22 2016 -0400 The lib/Net/Citadel/ToDo.pod file as of 22 August 2016. --- lib/Net/Citadel/ToDo.pod | 38 ++++++++++++++++++++------------------ 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/lib/Net/Citadel/ToDo.pod b/lib/Net/Citadel/ToDo.pod index 014f39a..5111707 100644 --- a/lib/Net/Citadel/ToDo.pod +++ b/lib/Net/Citadel/ToDo.pod @@ -9,8 +9,6 @@ Net::Citadel::ToDo - To Do items for the Net::Citadel Perl extension. =head2 General -Add a ZIPFLAGS configuration item for dist/zipdist in Makefile.PL? - Add a note in the documentation about the Net::Citadel repository and home page at GitHub? Also include a reference to where it is available at the C<gitpan> CPAN mirror at GitHub? @@ -28,27 +26,27 @@ There are some numbers being used that are actually constants; change to using Readonly to define them for use in the code, unless there are other standard constants that can be used, like those for the flock operations. -Add a paragraph to the documentation after the CONSTANTS header. - -Add a paragraph to the documentation after the 'Results Code' header, perhaps -including a link to the online status codes page in Citadel Documentation. - -Add a paragraph to the documentation after the 'Room Access' header, perhaps -including a link to the online page in Citadel Documentation that refers to -them. - A "000" string constant is used quite often by Citadel but is not defined in the module. There is a set of follow up reply codes noted in the documentation that are not yet in the module. +Add a link to the online documentation for the status codes: +http://www.citadel.org/doku.php?id=documentation:appproto:statuscodes + A C<NO_SUCH_USER> return code is mentioned in the command documentation (for -the USER command, for instance,) but the module doesn't currently appear to +the USER command, for instance,) but the module does not currently appear to define it. -Add a link to the online documentation for the status codes: -http://www.citadel.org/doku.php?id=documentation:appproto:statuscodes +Add a paragraph to the documentation after the CONSTANTS header. + +Add a paragraph to the documentation after the 'Results Code' header, perhaps +including a link to the online status codes page in Citadel Documentation. + +Add a paragraph to the documentation after the 'Room Access' header, perhaps +including a link to the online page in Citadel Documentation that refers to +them. =head2 Functions @@ -97,7 +95,7 @@ from the TIME command: C<1347624956|-14400>. The Citadel TIME command itself actually returns a line like this: C<200 1347625545|-14400|1|1347537300>, with the '200' being the OK code and the rest being the four fields that it returns (which also needs to be documented). So as currently written, the -function doesn't return the daylight savings time indication and the actual +function does not return the daylight savings time indication and the actual citadel server start information. Function first needs to be changed to at least return all parameters. @@ -111,7 +109,7 @@ to reflect the changes. =item C<citadel_echo> function It appears to test if what was sent, was actually received back but it only -returns true if it doesn't fail because there is no match. Add an explicit +returns true if it does not fail because there is no match. Add an explicit return of the value returned from the ECHO command? =back @@ -125,6 +123,10 @@ of the module? =head2 Testing +Will the differences with the newer Citadels justify or neccessitate checking +the version of the Citadel being tested and doing different tests depending +on that version? + Change the names of the test floors and rooms to something like C<Test Floor> and C<Test Room>? @@ -155,7 +157,7 @@ Use Config::YAML::Tiny instead of Config::YAML? (Does not appear to be in Debian as yet, although YAML::Tiny is.) Use something like Test::MockObject to do at least basic testing of the -various functions. And/or Test::TCP? +various functions. And/or Test::TCP? Testing of the citadel_info function currently just checks the number of information lines returned by the server. That could change over time and @@ -175,7 +177,7 @@ Robert James Clay, C<< <jame at rocasa.us> >> =head1 COPYRIGHT AND LICENSE -Copyright 2013 Robert James Clay, all rights reserved. +Copyright 2016 Robert James Clay, all rights reserved. This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/libnet-citadel-perl.git _______________________________________________ Pkg-perl-cvs-commits mailing list Pkgemail@example.com http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-perl-cvs-commits