This is an automated email from the git hooks/post-receive script. intrigeri pushed a commit to branch wheezy in repository libgtk2-perl.
commit 9b0b3f6288143b9c7ec6e58542e162ff4a58d2f6 Author: intrigeri <[email protected]> Date: Wed Feb 18 18:44:29 2015 +0000 Fix-incorrect-memory-management-in-Gtk2-Gdk-Display-list_devices.patch: new patch, cherry-picked from upstream, that fixes security issue. --- ...nagement-in-Gtk2-Gdk-Display-list_devices.patch | 47 ++++++++++++++++++++++ debian/patches/series | 1 + 2 files changed, 48 insertions(+) diff --git a/debian/patches/Fix-incorrect-memory-management-in-Gtk2-Gdk-Display-list_devices.patch b/debian/patches/Fix-incorrect-memory-management-in-Gtk2-Gdk-Display-list_devices.patch new file mode 100644 index 0000000..6640c67 --- /dev/null +++ b/debian/patches/Fix-incorrect-memory-management-in-Gtk2-Gdk-Display-list_devices.patch @@ -0,0 +1,47 @@ +From: Torsten Schönfeld <[email protected]> +Date: Sat, 17 Jan 2015 14:59:24 +0100 +Origin: https://git.gnome.org/browse/perl-Gtk2/commit/?id=4856da628ce37099b27b66a88141dc6daad693b0 +Applied-Upstream: 1.2495 +Subject: Fix incorrect memory management in Gtk2::Gdk::Display::list_devices + +We do not own the returned list. +--- + t/GdkDisplay.t | 4 +++- + xs/GdkDisplay.xs | 2 -- + 2 files changed, 3 insertions(+), 3 deletions(-) + +diff --git a/t/GdkDisplay.t b/t/GdkDisplay.t +index d290446..f4aef59 100644 +--- a/t/GdkDisplay.t ++++ b/t/GdkDisplay.t +@@ -1,7 +1,7 @@ + #!/usr/bin/perl -w + use strict; + use Gtk2::TestHelper +- tests => 26, ++ tests => 27, + at_least_version => [2, 2, 0, "GdkDisplay is new in 2.2"]; + + # $Id$ +@@ -32,6 +32,8 @@ ok(!$display -> pointer_is_grabbed()); + # $display -> beep(); + $display -> sync(); + ++# Do this twice to ensure we did not damage the list. ++isa_ok(($display -> list_devices())[0], "Gtk2::Gdk::Device"); + isa_ok(($display -> list_devices())[0], "Gtk2::Gdk::Device"); + + $display -> put_event(Gtk2::Gdk::Event -> new("button-press")); +diff --git a/xs/GdkDisplay.xs b/xs/GdkDisplay.xs +index f558f1d..a019eee 100644 +--- a/xs/GdkDisplay.xs ++++ b/xs/GdkDisplay.xs +@@ -69,8 +69,6 @@ gdk_display_list_devices (display) + devices = gdk_display_list_devices (display); + for (i = devices ; i != NULL ; i = i->next) + XPUSHs (sv_2mortal (newSVGdkDevice (i->data))); +- g_list_free (devices); +- + + GdkEvent* gdk_display_get_event (GdkDisplay *display) + diff --git a/debian/patches/series b/debian/patches/series index b9db011..95954ae 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -1,2 +1,3 @@ 30-disable_libgtk_version_check.patch fix-typo.patch +Fix-incorrect-memory-management-in-Gtk2-Gdk-Display-list_devices.patch -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-perl/packages/libgtk2-perl.git _______________________________________________ Pkg-perl-cvs-commits mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-perl-cvs-commits
