Your message dated Sun, 22 Oct 2017 21:09:17 +0000 with message-id <[email protected]> and subject line Bug#868232: fixed in postgresql-common 187 has caused the Debian Bug report #868232, regarding lost (unintentionally) unconditional pg_updatedicts on postinst to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 868232: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=868232 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: postgresql-common Version: 184 Severity: normal This is suggesting a fix for the recent autopkgtest errors like [1], more of them at [2]. TL;DR: - we should add an unconditional pg_updatedicts on "configure" in the postinst. - This bug is explaining the details and polling for opinions on adding that line Details: Formerly e.g. version 181 when installing on a clean system created /var/cache/postgresql: $ ls -dlaF /var/cache/postgresql ls: cannot access '/var/cache/postgresql': No such file or directory $ sudo apt install postgresql-common [...] $ ls -dlaF /var/cache/postgresql drwxr-xr-x 3 root root 4096 Jul 13 07:43 /var/cache/postgresql/ But now e.g. with version 184 it doesn't do that anymore: $ ls -dlaF /var/cache/postgresql ls: cannot access '/var/cache/postgresql': No such file or directory $ sudo apt install postgresql-common [...] $ ls -dlaF /var/cache/postgresql ls: cannot access '/var/cache/postgresql': No such file or directory The reason is the dropping of the following statement that was considered to be no more needed: if dpkg --compare-versions "$2" lt 94; then pg_updatedicts || true fi I agree version 94 is long ago. But since then, due to a mistake, this always was an unconditional pg_updatedicts call on first install. Quote from dpkg: "These treat an empty version as earlier than any version: lt le eq ne ge gt." Now on a new install of postgresql-common $2 is empty and so this triggered on first install since version 95. That in turn might seem unimportant, but affects cases where the first pg_updatedicts that is executed is under special conditions. Exactly that happens on the autopkgtests of postgresql-9.6 (or later). There the test dependencies install postgresql-common, as outlined above now without calling pg_updatedicts. Due to that the directory does not exist when the tests themselves call pg_updatedicts to update the dicts. But because they do so with a umask o 077 postgresql-common-184/testsuite: 22 : ${PG_UMASKS="077"} # default umask(s) to try [...] 169 umask $U [...] Finally t/150_tsearch_stemming.t will all pg_updatedicts in that env But due to the umask it is created as drwx------ 3 root root 4096 Jul 13 07:43 /var/cache/postgresql/ And that finally lets the test fail with an issue like in [1] === Running test 150_tsearch_stemming.t ... === [...[ not ok 9 - creating en_US full text search configuration ERROR: could not open dictionary file "/usr/share/postgresql/9.6/tsearch_data/en_us.dict": Permission denied Ok, long story short - we should make sure the base directory is created correctly on postinst. Therefor I suggest really adding an unconditional pg_updatedicts in there. The postrm already has the matching rm to clean the dir up btw. [1]: https://ci.debian.net/data/autopkgtest/unstable/amd64/p/postgresql-9.6/20170713_010956/log.gz [2]: https://ci.debian.net/packages/p/postgresql-9.6/unstable/amd64/ -- Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd
--- End Message ---
--- Begin Message ---Source: postgresql-common Source-Version: 187 We believe that the bug you reported is fixed in the latest version of postgresql-common, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Christoph Berg <[email protected]> (supplier of updated postgresql-common package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Sun, 22 Oct 2017 20:44:38 +0200 Source: postgresql-common Binary: postgresql-common postgresql-client-common postgresql-server-dev-all postgresql postgresql-client postgresql-doc postgresql-contrib postgresql-all Architecture: source Version: 187 Distribution: unstable Urgency: medium Maintainer: Debian PostgreSQL Maintainers <[email protected]> Changed-By: Christoph Berg <[email protected]> Description: postgresql - object-relational SQL database (supported version) postgresql-all - metapackage depending on all PostgreSQL server packages postgresql-client - front-end programs for PostgreSQL (supported version) postgresql-client-common - manager for multiple PostgreSQL client versions postgresql-common - PostgreSQL database-cluster manager postgresql-contrib - additional facilities for PostgreSQL (supported version) postgresql-doc - documentation for the PostgreSQL database management system postgresql-server-dev-all - extension build tool for multiple PostgreSQL versions Closes: 868232 872430 877920 Changes: postgresql-common (187) unstable; urgency=medium . * Consistently call psql -X. (Closes: #877920) * Update pt translation, thanks Ricardo Silva! (Closes: #872430) * pg_virtualenv: Drop "BUG" message that really just means that pg_createcluster threw an error. * pg_createcluster: Drop new cluster if --start was requested and starting fails. * pg_createcluster: If not running as postgres or root, don't attempt to install config and data parent directories with owner postgres. * pg_lsclusters, postgresql-generator, get_version_clusters, cluster_info, read_conf_file: Accept dead postgresql.conf symlinks, filesystem might not be mounted yet. * pg_virtualenv: Fix version comparison when determining newest PG major. * pg_updatedicts, postgresql-common.postinst: Create tsearch dictionaries on first install and set umask for correct permissions. (Closes: #868232) Thanks to Christian Ehrhardt for the analysis! * Demote postgresql-common hunspell/myspell triggers to noawait. Checksums-Sha1: da104e9eec2525a5003d02848540d834af0825ef 2339 postgresql-common_187.dsc 666c6cd0fdca478590912f1b3a49bc0ec0068bbc 205348 postgresql-common_187.tar.xz 5735723cb4721d7ea86269b147ab48b157e7bf71 5828 postgresql-common_187_source.buildinfo Checksums-Sha256: f0c403b82c09afab47c3d4e89d2ba9e2f9d929692bd43d6919db1ebdc9b21698 2339 postgresql-common_187.dsc 168f4383dde59a12e23504b60a45904ac2c7a05386ce67a35349a4a300058280 205348 postgresql-common_187.tar.xz 745c2bd6bbab90d3899e18770166ed5b464dbfe592bc1b1c6fbc76cedb76bf04 5828 postgresql-common_187_source.buildinfo Files: 2ce467a9c6059b01f14b7773532e3dc5 2339 database optional postgresql-common_187.dsc 32b322622be1906b59064e09d53924b4 205348 database optional postgresql-common_187.tar.xz 9833cf9763739d94470d5feaf3b4c0bc 5828 database optional postgresql-common_187_source.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEXEj+YVf0kXlZcIfGTFprqxLSp64FAlns78cACgkQTFprqxLS p643aw/+PCtbnZsuk6K72VORX/wGu69+DJgx3KfCT177Wn0+Hlrr3GWN7wTuclbp l4QkIC1BriXb7ciwiCP6Y0VwT+WZW/5+I6wqxNsLwh1UxVR05Yu8waSrvspHZ9Bz GL5+0oJjBEvaFmiLtrakiDRrGoPX0rh44qZKQpnmCAWHO9H506sGQGgYrRMt9qP9 ChTq/ks5A40PgvZMZ3kvDz/+8haN5rxz6HcuVZZ2yCnkdYbMNiEuhho4OMIuo0Ev YR1RJX/6vLE+gilr/cLpGu0QeaJ3HKV76AkuqyDwjCDham4kft1f76QMONmvJQuZ 7Th9Lzjg/e6Iyoom1bYuzzS/yVGV5pAkyT1NYnESb7KDYWDgKP58knA51wFkj7a1 XchhdRG3TDrlX6Rsb+0gHpX00BXGb+PPCfEWT7voJqFKkJkZrTGhsF/mTOKUAvJD oKo6JSDxz7PzRTdwphlwUyrq3J/r5+98hqSZN+7bwSyLJeCUAFkj5IrejhMqGrdh yJxnjOhOUd29tHNZOFFpxTMspHAqOyQafUfPF1knqDot+8uc6XB4qNvPOL06QO7j LNbLy9Spi36hVT95D0XuQFaPSK43Qp3UnWTc0zcFsdFRUecRCellNt7lP6MWTOup 06zmBxJdXNSdq9f73ji1uxu/NEXWRWcjY9QGS/3XciTFVNzLWvk= =MYmR -----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________ Pkg-postgresql-public mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-postgresql-public
