On 15 July 2016 at 08:56, Willem Mulder <[email protected]> wrote: > On Mon, 4 Jul 2016 11:08:17 -0300 Felipe Sateler <[email protected]> > wrote: >> On 4 July 2016 at 09:56, Yuri D'Elia <[email protected]> wrote: >> > Package: pulseaudio >> > Version: 9.0-1 >> > Followup-For: Bug #794650 >> > >> > I would second having a separate pulseaudio-qpaeq, as well as moving the >> > actual >> > plugin (so) to this package. >> > >> > Having the equalizer plugin without having the interface to control > it is >> > completely useless. >> >> Agreed. But I have not had time to do this. Patches welcome ;) > > I was slightly annoyed about this, so I decided to create a patch :)
Thanks! :) > I based the patch on the package's git repo. I'd also like some feedback > on it, since this is the first time I actually did something like this. The patch looks good, but there are some questions that need to be resolved first: 1. Is the equalizer sink useful without qpaeq? 2. Do users actually want the module, or the equalizer? As I understand it, the answer to 1 is: not at the moment, qpaeq is the only available client; this makes the answer to 2 "no". Therefore, I think the new package should be called qpaeq, and describe the equalizer application. Other than that, it looks good. The only unfortunate thing is that it won't work by default as the dbus module is not loaded in the default configuration. But fixing this would mean patching upstream code, which is more work (and I don't think it should block actually shipping the app). Did you test that the (python) dependencies you added are enough to run the app? Ie, install on a clean system/chroot and that it starts? -- Saludos, Felipe Sateler _______________________________________________ pkg-pulseaudio-devel mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-pulseaudio-devel
