Sorry for the very delayed response.  I'm trying to clean up our
outstanding bug list...

I'm not convinced that sharing the file is the correct thing to do - it
introduces thread-unsafe-ness between DebFile/ArFile and its dependent
objects that isn't obvious up front.

In addition, the existing behavior or re-opening the file by name is bad
for another reason: it leaks open files.

I think a better solution is probably something like:
  - If the input file is a "real" file, use mmap to get a view of the
    object for members.
  - Otherwise, we should probably iterate over the entire input object
    to generate our own file-like view of it, which itself supports an
    interface similar to mmap, and use that for member objects.

-- 
John Wright <[email protected]>

Attachment: signature.asc
Description: Digital signature

-- 
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-python-debian-maint

Reply via email to