On Mon, Apr 27, 2020 at 02:07:58PM +0200, Daniel Leidert wrote:
> tags 942596 + patch
> thanks
> 
> Hi there,
> 
> it seems Fedora people applied a patch to remove bundler usage from jekyll and
> make --skip-bundle behavior the default. Shall we use it too?
> 
> https://src.fedoraproject.org/rpms/rubygem-jekyll/blob/f30/f/0000-jekyll-commands-remove-bundle-install-step-for-new-c.patch

Yes. Although I would not remove the --skip-bundle option as that can
break scripts out there, and instead just assign `options["skip-bundle"]
= true` before doing anything (untested):

----------------8<----------------8<----------------8<-----------------
diff --git a/lib/jekyll/commands/new.rb b/lib/jekyll/commands/new.rb
index 09cee79..a85dbcb 100644
--- a/lib/jekyll/commands/new.rb
+++ b/lib/jekyll/commands/new.rb
@@ -16,6 +16,7 @@ module Jekyll
             c.option "skip-bundle", "--skip-bundle", "Skip 'bundle install'"
 
             c.action do |args, options|
+              options["skip-bundle"] = true
               Jekyll::Commands::New.process(args, options)
             end
           end
----------------8<----------------8<----------------8<-----------------

you would also need the changes to the test suite I think.

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Pkg-ruby-extras-maintainers mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-ruby-extras-maintainers

Reply via email to