Control: tags -1 + patch On Tue, Dec 13, 2022 at 09:32:12PM +0000, Cool Fire wrote: > Hello, > > On Tue, 13 Dec 2022 09:54:05 -0300 Antonio Terceiro <[email protected]> > wrote: > > Please note that supporting nodejs from outside of the debian archive is > > not a priority. > > That's entirely understandable. > > > On Tue, 13 Dec 2022 09:54:05 -0300 Antonio Terceiro <[email protected]> > wrote: > > I'm not making any promises, but if you can identify the fix yourself > > and check whether it applies to the passenger version in stable (or do > > the necessary backporting) in a way that doesn't break usage with nodejs > > from stable, I could provide a stable update with that fix. > > I've made some quick and dirty docker containers to validate that replacing > the "GLOBAL" with "global" is really all that is needed to fix the issue, > and that it does not break for deployments using the nodejs version from the > debian repos: https://git.insomnia247.nl/coolfire/passenger-tests > > As for actually writing the patch file needed for the package and how I > would go about submitting that, a few pointers would be greatly appreciated > if you can find the time.
These binaries have the attached patch applied, please try them (I'm assuming you are on amd64) and let me know. https://people.debian.org/~terceiro/tmp/passenger-bullseye/
From: Antonio Terceiro <[email protected]> Date: Tue, 13 Dec 2022 19:43:33 -0300 Subject: node-loader.js: drop usage of deprecated GLOBAL variable This enables running NodeJS apps in passenger using a newer NodeJS than the one in Debian bullseye. Even in the NodeJS version in stable, `GLOBAL` is already deprecated in favor or `global`, and using the former gets you a warning. Newer NodeJS versions drop `GLOBAL` completely, so passenger doesn't work at all with those. Bug-Vendor: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1025220 --- src/helper-scripts/node-loader.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/helper-scripts/node-loader.js b/src/helper-scripts/node-loader.js index 1e81ce6..38beba7 100644 --- a/src/helper-scripts/node-loader.js +++ b/src/helper-scripts/node-loader.js @@ -38,7 +38,7 @@ var instrumentModulePaths = [ 'phusion_passenger/log_express', 'phusion_passenge var instrumentedModules = []; module.isApplicationLoader = true; // https://groups.google.com/forum/#!topic/compoundjs/4txxkNtROQg -GLOBAL.PhusionPassenger = exports.PhusionPassenger = new EventEmitter(); +global.PhusionPassenger = exports.PhusionPassenger = new EventEmitter(); var stdinReader = new LineReader(process.stdin); beginHandshake(); readInitializationHeader();
signature.asc
Description: PGP signature
_______________________________________________ Pkg-ruby-extras-maintainers mailing list [email protected] https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-ruby-extras-maintainers
