Package: ruby-activerecord-3.2
Severity: important
Tags: security, patch
http://seclists.org/oss-sec/2012/q2/449
"""
Unsafe Query Generation Risk in Ruby on Rails
There is a vulnerability when Active Record is used in conjunction with
parameter parsing from Rack via Action Pack. This vulnerability has been
assigned the CVE identifier CVE-2012-2660.
Versions Affected: ALL versions
Not affected: NONE
Fixed Versions: 3.2.4, 3.1.5, 3.0.13
Impact
------
Due to the way Active Record interprets parameters in combination with the way
that Rack parses query parameters, it is possible for an attacker to issue
unexpected database queries with "IS NULL" where clauses. This issue does
*not* let an attacker insert arbitrary values into an SQL query, however they
can cause the query to check for NULL where most users wouldn't expect it.
For example, a system has password reset with token functionality:
unless params[:token].nil?
user = User.find_by_token(params[:token])
user.reset_password!
end
An attacker can craft a request such that `params[:token]` will return `[nil]`.
The `[nil]` value will bypass the test for nil, but will still add an "IS
NULL" clause to the SQL query.
All users running an affected release should either upgrade or use one of the
work arounds immediately.
Releases
--------
The FIXED releases are available at the normal locations.
Workarounds
-----------
This problem can be mitigated by testing for `[nil]`. For example:
unless params[:token].nil? || params[:token] == [nil]
user = User.find_by_token(params[:token])
user.reset_password!
end
Another possible workaround is to cast to a known type and test against that
type. For example:
unless params[:token].to_s.empty?
user = User.find_by_token(params[:token])
user.reset_password!
end
Patches
-------
To aid users who aren't able to upgrade immediately we have provided patches
for the two supported release series. They are in git-am format and consist of
a single changeset.
* 3-0-null_param.patch - Patch for 3.0 series
* 3-1-null_param.patch - Patch for 3.1 series
* 3-2-null_param.patch - Patch for 3.2 series
Please note that only the 3.1.x and 3.2.x series are supported at present.
Users of earlier unsupported releases are advised to upgrade as soon as
possible as we cannot guarantee the continued availability of security fixes
for unsupported releases.
Credits
-------
Thanks to Ben Murphy for reporting the vulnerability to us, and to Chad Pyne of
thoughtbot for helping us verify the fix.
"""
-- System Information:
Debian Release: 6.0.5
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.32-5-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL
set to en_US.UTF-8)
Shell: /bin/sh linked to /bin/dash
_______________________________________________
Pkg-ruby-extras-maintainers mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-ruby-extras-maintainers
