[DRE-maint] Bug#705466: libactionpack-ruby1.8: form_options_helper.rb method add_options do not render option_tags correct

[Hubert Krause]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Package: libactionpack-ruby1.8
Version: 2.3.5-1.2+squeeze8
Severity: normal
Tags: patch

the last update of libactionpack-ruby1.8 leads to a malfunction in
redmine backport version 1.1.2-2~bpo60+1.

The problem is, that an option list rendered by add_options with an
initial empty option leads to escaped option tags. An example:

<option value=""></option>
&lt;optgroup label=&quot;Test&quot;&gt;&lt;option
value=&quot;168&quot;&gt;Example&lt;/option&gt; &lt;option
value=&quot;167&quot;&gt;Example2 2013&lt;/option&gt; &lt;option
value=&quot;170&quot;&gt;Example 3 2013&lt;/option&gt; &lt;option
value=&quot;165&quot;&gt;Example
4&lt;/option&gt;&lt;/optgroup&gt;&lt;optgroup
label=&quot;Text&quot;&gt;&lt;option
value=&quot;105&quot;&gt;Livegang&lt;/option&gt; &lt;option
value=&quot;231&quot;&gt;Test91 &lt;/option&gt;&lt;/optgroup&gt;

The attached Patch solve this problem, but this patch introduce a
regression to the last patch. I put this patch to this bug report to
help figure out what the real problem might be. I don't know.

Best regards,

Hubert

- -- System Information:
Debian Release: 6.0.7
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-openvz-amd64 (SMP w/16 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages libactionpack-ruby1.8 depends on:
ii  libruby1.8           1.8.7.302-2squeeze1 Libraries necessary to run
Ruby 1.

libactionpack-ruby1.8 recommends no packages.

libactionpack-ruby1.8 suggests no packages.

- -- no debconf information
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAlFr4foACgkQFUpf3meJP55EMgCcCOXogmM5H//Qk6gCpIjIRX/S
w2EAoMIwEoH2lv64tz4W025asdxkshUV
=acig
-----END PGP SIGNATURE-----

--- bla/usr/lib/ruby/1.8/action_view/helpers/form_options_helper.rb     2013-03-27 18:41:10.000000000 +0100
+++ /usr/lib/ruby/1.8/action_view/helpers/form_options_helper.rb        2013-04-15 12:48:06.648542922 +0200
@@ -569,7 +569,7 @@
       private
         def add_options(option_tags, options, value = nil)
           if options[:include_blank]
-            option_tags = content_tag('option', options[:include_blank].kind_of?(String) ? options[:include_blank] : nil, :value => '') + "\n" + option_tags
+            option_tags = "<option value=\"\">#{options[:include_blank] if options[:include_blank].kind_of?(String)}</option>\n" + option_tags
           end
           if value.blank? && options[:prompt]
             prompt = options[:prompt].kind_of?(String) ? options[:prompt] : I18n.translate('support.select.prompt', :default => 'Please select')

_______________________________________________
Pkg-ruby-extras-maintainers mailing list
Pkg-ruby-extras-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-ruby-extras-maintainers