Your message dated Fri, 12 Jul 2013 23:48:37 +0000
with message-id <[email protected]>
and subject line Bug#715013: fixed in ruby-indentation 0.0.7-2
has caused the Debian Bug report #715013,
regarding Tests not automatically run on package build
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
715013: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=715013
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ruby-indentation
Version: 0.0.7-1
User: [email protected]
Usertags: origin-ubuntu saucy ubuntu-patch
Downstream bug: https://launchpad.net/bugs/1197894
ruby-indentation upstream provides test in spec/indentation_spec.rb, but
these are not automatically run by dh_ruby --test as part of the package
build.
The problem seems to be that although debian/ruby-test-files.yaml lists
spec/indentation_spec.rb, running spec/indentation_spec.rb itself does not
actually run the tests. So I think the problem here is that the packaging makes
assumptions about the tests provided by upstream, which don't hold, so dh_ruby
--test does not test anything.
Adding:
require 'rspec/autorun'
below the rspec require line in spec/spec_helper.rb fixes the problem,
as does adding an override_dh_auto_test of "rspec".
I'm not a Ruby specialist, so I don't know what the best practice fix
for this would be. It looks like using rspec/autotest is optional as far
as rspec upstream are concerned, so if upstream don't want to use it,
then perhaps the Debian packaging should use a different test
specification to dh_ruby, or override dh_auto_test as above.
I've applied the following fix in Ubuntu for now:
diff -Nru ruby-indentation-0.0.7/debian/rules
ruby-indentation-0.0.7/debian/rules
--- ruby-indentation-0.0.7/debian/rules 2013-05-06 02:39:32.000000000 +0000
+++ ruby-indentation-0.0.7/debian/rules 2013-07-05 12:38:30.000000000 +0000
@@ -13,3 +13,8 @@
%:
dh $@ --buildsystem=ruby --with ruby
+
+override_dh_auto_test:
+ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
+ rspec
+endif
--- End Message ---
--- Begin Message ---
Source: ruby-indentation
Source-Version: 0.0.7-2
We believe that the bug you reported is fixed in the latest version of
ruby-indentation, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Cédric Boutillier <[email protected]> (supplier of updated ruby-indentation
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 13 Jul 2013 01:31:39 +0200
Source: ruby-indentation
Binary: ruby-indentation
Architecture: source all
Version: 0.0.7-2
Distribution: unstable
Urgency: low
Maintainer: Debian Ruby Extras Maintainers
<[email protected]>
Changed-By: Cédric Boutillier <[email protected]>
Description:
ruby-indentation - Ruby extensions for Array and String classes
Closes: 715013
Changes:
ruby-indentation (0.0.7-2) unstable; urgency=low
.
* Team upload
* debian/control:
+ remove obsolete DM-Upload-Allowed flag
+ use canonical URI in Vcs-* fields
* debian/ruby-test-files.yaml: add rspec/autorun to the list
so that specs are run (Closes: #715013)
Checksums-Sha1:
f8c6041ff133ee5bc1eaedb09b5fdf69c5ba3e2e 2101 ruby-indentation_0.0.7-2.dsc
124d8e506b637e191149f620a02d1247feec4334 2369
ruby-indentation_0.0.7-2.debian.tar.gz
16ac5b0aa7d7894124b165a764d80f2afde506b7 6428 ruby-indentation_0.0.7-2_all.deb
Checksums-Sha256:
87f920f34e3623d6f534d7da46681bc83f41f69f66d407228d5c0bcd5f730c50 2101
ruby-indentation_0.0.7-2.dsc
cea5ce52c65bb0a1852adad510125db3bedcbc92e62d79787ec683b34e9886a8 2369
ruby-indentation_0.0.7-2.debian.tar.gz
a8b5cd48d1d8cc050b4b8f7713404fb41a7c0d331dedc4c59812be5791dfb9a2 6428
ruby-indentation_0.0.7-2_all.deb
Files:
c019c0bc6901c9a8a4daf276b049083b 2101 ruby optional
ruby-indentation_0.0.7-2.dsc
2cbe318c4c0046e974795fca47e17d07 2369 ruby optional
ruby-indentation_0.0.7-2.debian.tar.gz
9ed68ddbf2998835468d28cd92b6f64b 6428 ruby optional
ruby-indentation_0.0.7-2_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBCAAGBQJR4JOUAAoJENpJWPYR4Unp88QP/jhbsKrI6dkSBRvbMVN4tinb
StaGiNAHozJXu3TaTZDtwWMtwO9eCY4aWig2yvCop1DIY45v8KYlNIuw7YJA6T/U
q0wr8luZEGxMuU6C582ijjzJh/iuTWKrL+Fvl82ex0ABXS5DzaYdid64sdf715/N
yG4sfxCygEffgfomcK1UU2zOTXzBKIhji3IX8mDE/RrwTNIHiTgOdJB4r3iv7RHM
YxPKsHjX5mt58XI+HB/6UmfQyMWOXj5QajYQJGD7t2NX6wpBEYOYD4q58aMko8gC
BhED08Z4t6G/aklih0rIVqfxbRSRDCIixnkYkwGWKsu25kudJyXEVgHdF0flzu/j
ctjw7Wldjl6h/6sY3QQzu02IL9taMGcWRhznhsZJvKEGnhcdWJKF9BUbrw1DA9bQ
Vfzj85QeAd5lnulxTH2XYE7u8ojWHyMcfq88SYR2h1FJXqp7Us5CyhRDHxaA8mv1
COTMlCbZOG0auBhizsRKNC+dT7DLzjbN525nZndmi9bg0FS5P4bJHvjiia7CrKT6
bb5hZshq20ghmuyGNPmZK6vYGNyIbZ2Y3h33X9P+zKbA0TyQzRFQ4rLJUngSSHYd
wl4OH1k5Qp/QRiCUwdj5oQ2gBS8iOf9oOMRuJ2qZ2AEVKm4jOsWYo41xgBxIcKAl
LnaLcZHoUaUwDjmmxZCZ
=wvfI
-----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________
Pkg-ruby-extras-maintainers mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-ruby-extras-maintainers
