Your message dated Fri, 23 Oct 2015 09:22:46 -0200
with message-id <[email protected]>
and subject line Re: Bug#802762: bundler: Please re-add the 
/var/lib/gems/<version> directories
has caused the Debian Bug report #802762,
regarding bundler: Please re-add the /var/lib/gems/<version> directories
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
802762: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=802762
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: bundler
Version: 1.10.6-2
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-kali kali-patch

Hello,

I noticed that in version 1.9.9-1 you stopped shipping the
/var/lib/gems/<version> directories justifying this with a bug of
your own (#782148). The bug is not very clear but apparently
you were not happy of having directories for old versions...

I want those directories back because bundler does not work
out of the box without those directories. At least not for
the use we make of it in Kali.

We have many Ruby applications relying on bundler and we package
all the ruby modules ourselves. At build time we run something
like this to ensure that we have all the modules in the desired
versions.

        # Just ensure that we have the required deps
        bundle install --local --no-cache --without test

But this call fails when /var/lib/gems/<version> does not exist.

So I would like you to apply the attached patch. It will rely
on ruby-all-dev to create only the directories that are actually
needed for the supported ruby versions (right now 2.1.0 and 2.2.0).

Thank you!

-- System Information:
Debian Release: stretch/sid
  APT prefers squeeze-lts
  APT policy: (500, 'squeeze-lts'), (500, 'oldoldstable'), (500, 'unstable'), 
(500, 'testing'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.2.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages bundler depends on:
ii  ruby                        1:2.1.5.1
ii  ruby-molinillo              0.2.3-1
ii  ruby-net-http-persistent    2.9-3
ii  ruby-thor                   0.19.1-2
ii  ruby2.1 [ruby-interpreter]  2.1.5-4
ii  ruby2.2 [ruby-interpreter]  2.2.3-1
ii  rubygems-integration        1.9

Versions of packages bundler recommends:
ii  build-essential  12.1
ii  less             458-3
ii  ruby-dev         1:2.1.5.1
ii  sudo             1.8.12-1

bundler suggests no packages.

-- no debconf information

-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: http://www.freexian.com/services/debian-lts.html
Learn to master Debian: http://debian-handbook.info/get/
diff -Nru bundler-1.10.6/debian/control bundler-1.10.6/debian/control
--- bundler-1.10.6/debian/control       2015-10-01 23:44:55.000000000 +0200
+++ bundler-1.10.6/debian/control       2015-10-19 12:15:53.000000000 +0200
@@ -8,7 +8,8 @@
                gem2deb (>= 0.6.0~),
                rake,
                ruby-rspec,
-               ruby-thor
+               ruby-thor,
+               ruby-all-dev
 Standards-Version: 3.9.6
 Vcs-Git: git://anonscm.debian.org/pkg-ruby-extras/bundler.git
 Vcs-Browser: https://anonscm.debian.org/cgit/pkg-ruby-extras/bundler.git
diff -Nru bundler-1.10.6/debian/rules bundler-1.10.6/debian/rules
--- bundler-1.10.6/debian/rules 2015-10-01 23:44:55.000000000 +0200
+++ bundler-1.10.6/debian/rules 2015-10-23 10:19:08.000000000 +0200
@@ -1,6 +1,8 @@
 #!/usr/bin/make -f
 export GEM2DEB_TEST_RUNNER = --check-dependencies
 
+RUBY_API_VERSIONS := $(shell ruby -r ruby_debian_dev.rb -e 'puts 
RubyDebianDev.const_get("RUBY_API_VERSION").values()')
+
 %:
        dh $@ --buildsystem=ruby --with ruby
 
@@ -11,3 +13,9 @@
 override_dh_installchangelogs:
        dh_installchangelogs -i CHANGELOG.md
 
+override_dh_installdirs:
+       dh_installdirs
+       # Create the /var/lib/gems/<version> directories that bundler expects
+       for version in $(RUBY_API_VERSIONS); do \
+           mkdir -p debian/bundler/var/lib/gems/$$version; \
+       done

--- End Message ---
--- Begin Message ---
Control: tag -1 + wontfix

Hi Raphael,

On Fri, Oct 23, 2015 at 10:32:46AM +0200, Raphael Hertzog wrote:
> diff -Nru bundler-1.10.6/debian/rules bundler-1.10.6/debian/rules
> --- bundler-1.10.6/debian/rules       2015-10-01 23:44:55.000000000 +0200
> +++ bundler-1.10.6/debian/rules       2015-10-23 10:19:08.000000000 +0200
> @@ -1,6 +1,8 @@
>  #!/usr/bin/make -f
>  export GEM2DEB_TEST_RUNNER = --check-dependencies
>  
> +RUBY_API_VERSIONS := $(shell ruby -r ruby_debian_dev.rb -e 'puts 
> RubyDebianDev.const_get("RUBY_API_VERSION").values()')
> +
>  %:
>       dh $@ --buildsystem=ruby --with ruby
>  
> @@ -11,3 +13,9 @@
>  override_dh_installchangelogs:
>       dh_installchangelogs -i CHANGELOG.md
>  
> +override_dh_installdirs:
> +     dh_installdirs
> +     # Create the /var/lib/gems/<version> directories that bundler expects
> +     for version in $(RUBY_API_VERSIONS); do \
> +         mkdir -p debian/bundler/var/lib/gems/$$version; \
> +     done

this means bundler would have to be rebuilt when there is any change the
supported versions, which is not very practical.

starting with ruby2.2, the interpreter itself will already include the
necessary directory on its own:

$ dpkg -L ruby2.2 | grep var.lib
/var/lib
/var/lib/gems
/var/lib/gems/2.2.0

we want to _remove_ ruby2.1 as soon as possible, so for stretch this
will soon become a non-issue.

-- 
Antonio Terceiro <[email protected]>

Attachment: signature.asc
Description: PGP signature


--- End Message ---
_______________________________________________
Pkg-ruby-extras-maintainers mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-ruby-extras-maintainers

Reply via email to