* Miguel Landaeta <[email protected]> [170313 19:45]: > I noticed ruby-json Java extension was not being built from this > package. > > So, since I need that to get JRuby unit tests passing and it should be > useful for real-world users, I added that missing component to this > package. > > If there are no objections to my approach (please see the debdiff > below), I was planning to merge this and do an upload to experimental > very soon.
Looks mostly good to me. One thing: > diff -Nru ruby-json-2.0.1+dfsg/debian/control > ruby-json-2.0.1+dfsg/debian/control > --- ruby-json-2.0.1+dfsg/debian/control 2016-12-05 23:33:24.000000000 > +0000 > +++ ruby-json-2.0.1+dfsg/debian/control 2017-03-13 11:54:41.000000000 > +0000 > @@ -6,7 +6,11 @@ > Antonio Terceiro <[email protected]>, > Cédric Boutillier <[email protected]> > Build-Depends: debhelper (>= 9~), > + default-jdk, > gem2deb, > + git, ^^^ Is git actually needed for the build? As far as I can see from the build log, the git call ends up emitting just this error: > fatal: Not a git repository (or any of the parent directories): .git -ch _______________________________________________ Pkg-ruby-extras-maintainers mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-ruby-extras-maintainers
