On Thu, Mar 23, 2017 at 03:03:58PM +0000, Pirate Praveen wrote: > gitlab (8.13.11+dfsg-8) unstable; urgency=medium > * Be more defensive in rm -rf https://anonscm.debian.org/cgit/pkg-ruby-extras/gitlab.git/commit/?id=33eb420ac6a10cee51a1031d31ba31179efb3ebd is pointless. a.) the loop is useless, there's a "rm -rf $gitlab_data_dir" later anyway, and b.) those, tests are useless too, 1.) it's rm _-f_ anyway, b.) test -e / also returns true…
what you really what to test is whether the directory to be deleted is a
sensible one to be deleted… (eg whether the path starts with /var/lib/gitlab
or whatever is sensible here.)
--
cheers,
Holger
signature.asc
Description: Digital signature
_______________________________________________ Pkg-ruby-extras-maintainers mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-ruby-extras-maintainers
