Your message dated Wed, 21 Mar 2018 18:05:27 +0000
with message-id <[email protected]>
and subject line Bug#890757: fixed in gitlab 10.5.5+dfsg-1
has caused the Debian Bug report #890757,
regarding gitlab: Error 500 when issue has code block to render
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
890757: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890757
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: gitlab
Version: 9.5.4+dfsg-5
Severity: normal

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hello,
when issue has some code block to render, there is error 500 in dashboard

Started GET "/dashboard/activity?limit=20&offset=0" for x.x.x.x at 2018-02-18 
07:53:57 +0100
Processing by DashboardController#activity as JSON
  Parameters: {"limit"=>"20", "offset"=>"0"}
Completed 500 Internal Server Error in 586ms (ActiveRecord: 41.3ms)

ActionView::Template::Error (undefined method `html_escape' for 
#<Banzai::Renderer::HTML:0x0000557b9f3b4ca8>
Did you mean?  html_safe?):
    10: .event-body
    11:   .event-note
    12:     .md
    13:       = event_note(event.target.note, project: event.project)
    14:     - note = event.target
    15:     - if note.attachment.url
    16:       - if note.attachment.image?
  lib/banzai/renderer/html.rb:8:in `block_code'
  lib/banzai/filter/markdown_filter.rb:10:in `render'
  lib/banzai/filter/markdown_filter.rb:10:in `call'
  lib/banzai/pipeline/base_pipeline.rb:21:in `block (2 levels) in singleton 
class'
  lib/banzai/renderer.rb:107:in `render_result'
  lib/banzai/renderer.rb:138:in `block in cacheless_render'
  lib/gitlab/metrics/influx_db.rb:92:in `measure'
  lib/banzai/renderer.rb:137:in `cacheless_render'
  lib/banzai/renderer.rb:28:in `render'
  lib/banzai.rb:3:in `render'
  app/helpers/markup_helper.rb:220:in `markdown_unsafe'
  app/helpers/markup_helper.rb:79:in `markdown'
  app/helpers/markup_helper.rb:70:in `first_line_in_markdown'
  app/helpers/events_helper.rb:174:in `event_note'
  app/views/events/event/_note.html.haml:13:in 
`_app_views_events_event__note_html_haml___3195316608961436102_46994720833940'
  app/views/events/_event.html.haml:11:in 
`_app_views_events__event_html_haml__2698820872038661657_46994679561920'
  app/views/events/_events.html.haml:1:in 
`_app_views_events__events_html_haml___93854884984734810_46994679725040'
  app/controllers/application_controller.rb:234:in `pager_json'
  app/controllers/dashboard_controller.rb:17:in `block (2 levels) in activity'
  app/controllers/dashboard_controller.rb:12:in `activity'
  lib/gitlab/i18n.rb:46:in `with_locale'
  lib/gitlab/i18n.rb:52:in `with_user_locale'
  app/controllers/application_controller.rb:326:in `set_locale'
  lib/gitlab/middleware/multipart.rb:93:in `call'
  lib/gitlab/request_profiler/middleware.rb:14:in `call'
  lib/gitlab/middleware/go.rb:17:in `call'
  lib/gitlab/etag_caching/middleware.rb:11:in `call'
  lib/gitlab/request_context.rb:18:in `call'
  lib/gitlab/metrics/requests_rack_middleware.rb:27:in `call'

and isssue detail
Started GET "/group/project/issues/4097" for x.x.x.x at 2018-02-18 07:54:02 
+0100
Processing by Projects::IssuesController#show as HTML
  Parameters: {"namespace_id"=>"group", "project_id"=>"project", "id"=>"4097"}
Completed 500 Internal Server Error in 67ms (ActiveRecord: 21.6ms)

NoMethodError (undefined method `html_escape' for 
#<Banzai::Renderer::HTML:0x0000557b9f3b4ca8>
Did you mean?  html_safe?):
  lib/banzai/renderer/html.rb:8:in `block_code'
  lib/banzai/filter/markdown_filter.rb:10:in `render'
  lib/banzai/filter/markdown_filter.rb:10:in `call'
  lib/banzai/pipeline/base_pipeline.rb:21:in `block (2 levels) in singleton 
class'
  lib/banzai/renderer.rb:107:in `render_result'
  lib/banzai/renderer.rb:138:in `block in cacheless_render'
  lib/gitlab/metrics/influx_db.rb:92:in `measure'
  lib/banzai/renderer.rb:137:in `cacheless_render'
  lib/banzai/renderer.rb:49:in `cacheless_render_field'
  app/models/concerns/cache_markdown_field.rb:68:in `block in 
refresh_markdown_cache!'
  app/models/concerns/cache_markdown_field.rb:65:in `map'
  app/models/concerns/cache_markdown_field.rb:65:in `refresh_markdown_cache!'
  lib/banzai/renderer.rb:39:in `render_field'
  lib/banzai.rb:7:in `render_field'
  lib/banzai/object_renderer.rb:51:in `block in render_documents'
  lib/banzai/object_renderer.rb:50:in `map'
  lib/banzai/object_renderer.rb:50:in `render_documents'
  lib/banzai/object_renderer.rb:34:in `render'
  lib/banzai/note_renderer.rb:18:in `render'
  app/controllers/concerns/renders_notes.rb:5:in `prepare_notes_for_rendering'
  app/controllers/projects/issues_controller.rb:89:in `show'
  lib/gitlab/i18n.rb:46:in `with_locale'
  lib/gitlab/i18n.rb:52:in `with_user_locale'
  app/controllers/application_controller.rb:326:in `set_locale'
  lib/gitlab/middleware/multipart.rb:93:in `call'
  lib/gitlab/request_profiler/middleware.rb:14:in `call'
  lib/gitlab/middleware/go.rb:17:in `call'
  lib/gitlab/etag_caching/middleware.rb:11:in `call'
  lib/gitlab/request_context.rb:18:in `call'
  lib/gitlab/metrics/requests_rack_middleware.rb:27:in `call'

or saving new issue
Started POST "/root/test/issues" for x.x.x.x at 2018-02-18 13:50:08 +0100
Processing by Projects::IssuesController#create as HTML
  Parameters: {"utf8"=>"▒..", "authenticity_token"=>"[FILTERED]", 
"issue"=>{"title"=>"test", "description"=>"```\r\ntest\r\ntet\r\n```", 
"confidential"=>"0", "assignee_ids"=>["0"], "label_ids"=>[""], "due_date"=>"", 
"lock_version"=>""},
"namespace_id"=>"root", "project_id"=>"test"}
Completed 500 Internal Server Error in 40ms (ActiveRecord: 4.3ms)

NoMethodError (undefined method `html_escape' for 
#<Banzai::Renderer::HTML:0x000055a9f939d6d8>
Did you mean?  html_safe?):
  lib/banzai/renderer/html.rb:8:in `block_code'
  lib/banzai/filter/markdown_filter.rb:10:in `render'
  lib/banzai/filter/markdown_filter.rb:10:in `call'
  lib/banzai/pipeline/base_pipeline.rb:21:in `block (2 levels) in singleton 
class'
  lib/banzai/renderer.rb:107:in `render_result'
  lib/banzai/renderer.rb:138:in `block in cacheless_render'
  lib/gitlab/metrics/influx_db.rb:92:in `measure'
  lib/banzai/renderer.rb:137:in `cacheless_render'
  lib/banzai/renderer.rb:49:in `cacheless_render_field'
  app/models/concerns/cache_markdown_field.rb:68:in `block in 
refresh_markdown_cache!'
  app/models/concerns/cache_markdown_field.rb:65:in `map'
  app/models/concerns/cache_markdown_field.rb:65:in `refresh_markdown_cache!'
  app/services/issuable_base_service.rb:161:in `block in create_issuable'
  app/services/issuable_base_service.rb:160:in `create_issuable'
  app/services/issuable_base_service.rb:180:in `create'
  app/services/issues/create_service.rb:12:in `execute'
  app/controllers/projects/issues_controller.rb:106:in `create'
  lib/gitlab/i18n.rb:46:in `with_locale'
  lib/gitlab/i18n.rb:52:in `with_user_locale'
  app/controllers/application_controller.rb:326:in `set_locale'
  lib/gitlab/middleware/multipart.rb:93:in `call'
  lib/gitlab/request_profiler/middleware.rb:14:in `call'
  lib/gitlab/middleware/go.rb:17:in `call'
  lib/gitlab/etag_caching/middleware.rb:11:in `call'
  lib/gitlab/request_context.rb:18:in `call'
  lib/gitlab/metrics/requests_rack_middleware.rb:27:in `call'


It can be "fixed" by reverting edit of lib/banzai/filter/markdown_filter.rb from
https://gitlab.com/gitlab-org/gitlab-ee/commit/2e8aa209f013d567bb3956a3e4201d3b2d63fe10

but it's just a hack to make it working for us

Libor

-----BEGIN PGP SIGNATURE-----

iQJJBAEBCAAzFiEEPGZVVU37tFmB0TQv8O+MbsKfR44FAlqJgfkVHGxpYm9yLmts
ZXBhY0BiY29tLmN6AAoJEPDvjG7Cn0eO770P/iioawoiVWjdglwJV++7UsVFbYGT
jcNuLelCVECHgHD+HOoewlplPHEjaRCZKBVUo7TjBnfEJcgHlBHFhQUX8krX/TQ1
MUlfhju1EyQH3l0Gdu/ZVF+a+q/wXhhgG8Ht4XJ1ib1r75Mv+ky1buE9rCUA8mfh
sWUupza23IPQfru76LplcJeB8+wSL8yOl/43PueRKOlY5VPVBdaDxGjKtFGshu/P
VYPob2+vp1LOJVaWXeRBpI+cmJYIJBKAe/9K0uWS49VJiJJI6iC679v60OxZ4bSf
U19hXnUb9/N+km20Q7hG/REOVvzWMA0es+/Sf1jkkN1iK4w03bvQGzWySn2R/rZY
20MD2E1rvI+ru+sOUpQ3KTdUMNJ6QxzA4bzeIIctYHlHUvll2HlfKm1Id04T85F+
bR3zLkJW165QSHiTQ/Pslx2lDtYty+o3uEG3c/SevAeKwTtvAC/nnGiqfUrJMC4v
mAYkiC3zxAdhwMeVOBcIfRqGLT4so7bQoRJUc3tEa0ntylNMMVP8jGc0Qtw96UpD
SEKLo3tyI5T4OC/iRszB1nhwZ0FWI+fdcUEBLNqnspJ99jW5HHlXd3f31dbC+Ceo
vv7V2GQSgHI3dsi1Dsat4D80BIazu3g99p3fl9QnXKy4LjGFnfTqLroJQl0XVIDO
Pa25o5+7kO0Enoha
=qnE0
-----END PGP SIGNATURE-----

--- End Message ---
--- Begin Message ---
Source: gitlab
Source-Version: 10.5.5+dfsg-1

We believe that the bug you reported is fixed in the latest version of
gitlab, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Pirate Praveen <[email protected]> (supplier of updated gitlab package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 18 Mar 2018 15:17:08 +0530
Source: gitlab
Binary: gitlab
Architecture: source
Version: 10.5.5+dfsg-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Ruby Extras Maintainers 
<[email protected]>
Changed-By: Pirate Praveen <[email protected]>
Description:
 gitlab     - git powered software platform to collaborate on code (non-omnibus
Closes: 888508 890757
Changes:
 gitlab (10.5.5+dfsg-1) unstable; urgency=medium
 .
   [ Dmitry Smirnov ]
   * Depends += "ruby-excon (>= 0.60.0~)"
   * Added new patch to fix Markdown rendering (Closes: #890757).
   * Depends: set minimum version for "rake".
 .
   [ Pirate Praveen ]
   * New upstream version 10.5.5 (Closes: #888508)
     - Fixes multiple security vulnerabilities in 10.3.4 (CVE-2017-0914,
       CVE-2017-0916, CVE-2017-0917, CVE-2017-0918, CVE-2017-0923,
       CVE-2017-0925, CVE-2017-0926, CVE-2017-0927, CVE-2017-3710)
   * Remove files no longer present in vendor from Files-Excluded
   * Refresh patches
   * Add new node-* dependencies already in the archive as depends
   * Tighten dependencies
   * Bump debhelper compat to 10 and standards version to 4.1.3
Checksums-Sha1:
 8335491d4fa010ec1ae525b33c24f9ae300eb2b8 2523 gitlab_10.5.5+dfsg-1.dsc
 9f726e11889c0bd7f5e730c019f1468c349ee8fe 44727574 
gitlab_10.5.5+dfsg.orig.tar.gz
 76ba841f3f52f394c3ba1f3aa5eaeaa9a1b40b32 61472 
gitlab_10.5.5+dfsg-1.debian.tar.xz
 9ba15455174c4a67b7b2fc8fc2d99a5bd1d67ecf 8025 
gitlab_10.5.5+dfsg-1_source.buildinfo
Checksums-Sha256:
 a206cdf1042f34c33cfd339c41c97c380dfb2b31df3a0e30d9525c772f756db1 2523 
gitlab_10.5.5+dfsg-1.dsc
 d75e02a5c428bf5201ba6a96eeba7346dd16bb489093940b9623509b4d0f3654 44727574 
gitlab_10.5.5+dfsg.orig.tar.gz
 6af9dbaa6e1dec89abdc0bd2a3993f081296c155a871d80e3ad5a3fe07de1b14 61472 
gitlab_10.5.5+dfsg-1.debian.tar.xz
 e5a45f9e917c2ff6063ee079f60d1111994b1ac30a45ccef5097b103681716e7 8025 
gitlab_10.5.5+dfsg-1_source.buildinfo
Files:
 905ab61ee2a44a36c8af3491446616e7 2523 contrib/net optional 
gitlab_10.5.5+dfsg-1.dsc
 21f94a6b4537850d46fd7cece9d54d76 44727574 contrib/net optional 
gitlab_10.5.5+dfsg.orig.tar.gz
 193dff203a7aecff132699c058364c73 61472 contrib/net optional 
gitlab_10.5.5+dfsg-1.debian.tar.xz
 5db348f2df8c57f988f1cde2c3a1ea93 8025 contrib/net optional 
gitlab_10.5.5+dfsg-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEKnl0ri/BUtd4Z9pKzh+cZ0USwioFAlqymPgACgkQzh+cZ0US
wiolmQ/9HhPbci8NCEwMgQt907NrV5z0c12xecspXzWxShjK6oxhzr9mtmpYdkUF
T0ITuYaY0ChAPSZPaO8WilMk8MYD11o3Ebay73NwLm8mvIhTHBvTKuU4EbR8zYGw
gceVYcTTv4uBYwNp/VfHzAfq+xrqC/9uyy71OXFB73ddK/dm/kkUoevNvn67T6oq
cvpe82Zh8xAL+d/DLQv/SGiKewozrlFtzNkp4J87yrl1n4Solyc0Z+/6xvepMOal
aWwGE29fKo6bg44K3FKc3kqTiH3sNv6STpBf6a157Co5vSwpFhmPmWwjg8rk6GXo
nXFtlaQMZ4NVJZt1T4vemasryrciaEWqSg75bEzlODiBvg9qD5Nf+QfkRBDhWpBO
ue28i0EmRMd/FLQe6YFn6BY434q0cux6Gz/aqrXvlMAfw5bx+Qd4hQKa4KOGO3So
oXRhoS31KkIRaP3DGjAOKDNxw9975Hth2NWHhEjUGjkyzKJncAsNmuJna9AmmxX+
4UuxrGmBQxxlRE2kj2DTjwIXuXleSJM/tBLv/8lJWGL7QFOiH4/ABio30D3yr4WK
yP/oxdBqgFEGfnq+4j+h1ge9PV8cxNoON2YFOqVtiLkJK983/ZFZG2DsTVOhk6s0
BjbSCHTFQewzaIMgbawfmHD0XmMRbdCupO3uommF5QHiFNArEWM=
=Dh+N
-----END PGP SIGNATURE-----

--- End Message ---
_______________________________________________
Pkg-ruby-extras-maintainers mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-ruby-extras-maintainers

Reply via email to