Your message dated Fri, 20 Dec 2019 16:35:08 +0000
with message-id <[email protected]>
and subject line Bug#808301: fixed in shadow 1:4.8-1
has caused the Debian Bug report #808301,
regarding login: package description review
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
808301: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=808301
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: login
Version: 1:4.2-3.1
Severity: wishlist
Tags: patch
The long package description for login features some distinctly
non-native-speakerish grammar and some out-of-date assumptions. It's
still perfectly comprehensible, and a case could be made for the
argument that descriptions for "Essential: yes" packages don't much
matter (as no user ever needs to decide whether or not to install
login). On the other hand it's a high-profile package, so I thought
I'd submit a wishlist patch.
# Description: system login tools
A perfectly good synopsis.
# These tools are required to be able to login and use your system.
I see three problems here.
* This sentence starts awkwardly by luring readers up a garden-path
parsing involving a requirement that these tools should behave in a
certain way. There's no need for any phrasing this convoluted when
it could just say "You need these tools to..."
* "To login" is wrong. The noun and of course the executable may be
single words, but what's needed here is the verb, which is two
words - it's "I logged myself in", not "I logined myself".
* It's not true! Running "rm /bin/login" doesn't stop me logging in
and using my system via an SSH connection or an X display manager.
Next we run straight into a list of three executables in the package
and their functions. (The lack of context gives the impression that
it is intended as an exhaustive list of "these tools".)
# The
# login program invokes your user shell and enables command execution.
Since these three programs are being introduced here the more natural
English word-order would be "The program 'login'..." (though this
would be barely noticeable if it wasn't repeated).
But then the rest of the sentence is misleading. I don't need to use
login to get a shell - I get one free with every xterm; and executing
/bin/login achieves nothing, so from a user's point of view it's not
much of a "tool". The description omits the important thing about
login, which is that it's invoked by the getty process running on a
TTY (or these days by a systemd [email protected], however that works
exactly).
# The
# newgrp program is used to change your effective group ID (useful for
# workgroup type situations).
That's "The program 'newgrp'..."; then "workgroup-type situations"
needs a hyphen and is oddly informal alongside the complex impersonal
phrasing of these sentences (besides which, thanks to Microsoft the
word "workgroup" is hopelessly ambiguous). But more importantly, how
is "newgrp" important enough to deserve a mention here? Does anybody
ever use it? Instead I would suggest introducing /usr/sbin/nologin
here and leaving out newgrp along with sg, faillog, and lastlog.
(And in fact rather than this exclusive focus on the tools - i.e.
executables - in the package, it might also make sense to hint at the
presence of things like /etc/securetty and /etc/pam.d/login by saying
that the package provides "infrastructure".)
# The su program allows changing your effective
# user ID (useful being able to execute commands as another user).
First there's the repeated word-order niggle, then an unclear use of
"allow" (su doesn't just render EUID changes permissible, it directly
changes your EUID). And as for the part in parentheses... well, I
think it's just trying to say "useful for executing commands...", but
with entirely broken syntax.
This is also a bit dated, since I'm more likely these days to switch
UIDs with sudo (or pkexec or runuser) than with su.
My suggested thoroughly revised version:
Description: system login tools
This package provides some required infrastructure for logins and for
changing effective user or group IDs, including:
* login, the program that invokes a user shell on a virtual terminal;
* nologin, a dummy shell for disabled user accounts;
* su, a basic tool for executing commands as root or another user.
-- System Information:
Debian Release: stretch/sid
APT prefers testing
APT policy: (990, 'testing'), (50, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 4.4.0-rc4-686-pae (SMP w/1 CPU core)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages login depends on:
ii libaudit1 1:2.4.4-4
ii libc6 2.19-22
ii libpam-modules 1.1.8-3.1
ii libpam-runtime 1.1.8-3.1
ii libpam0g 1.1.8-3.1
login recommends no packages.
login suggests no packages.
-- no debconf information
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
diff -ru shadow-4.2.pristine/debian/control shadow-4.2/debian/control
--- shadow-4.2.pristine/debian/control 2014-11-19 20:49:09.000000000 +0000
+++ shadow-4.2/debian/control 2015-12-18 01:13:38.573144040 +0000
@@ -29,11 +29,11 @@
Replaces: manpages-de (<< 0.5-3), manpages-tr (<<1.0.5), manpages-zh (<<1.5.1-1), passwd (<< 1:4.1.5.1-2~) [hurd-any], coreutils (<< 8.21~) [hurd-any], hurd (<< 20140206~) [hurd-any]
Essential: yes
Description: system login tools
- These tools are required to be able to login and use your system. The
- login program invokes your user shell and enables command execution. The
- newgrp program is used to change your effective group ID (useful for
- workgroup type situations). The su program allows changing your effective
- user ID (useful being able to execute commands as another user).
+ This package provides some required infrastructure for logins and for
+ changing effective user or group IDs, including:
+ * login, the program that invokes a user shell on a virtual terminal;
+ * nologin, a dummy shell for disabled user accounts;
+ * su, a basic tool for executing commands as root or another user.
Package: uidmap
Priority: optional
--- End Message ---
--- Begin Message ---
Source: shadow
Source-Version: 1:4.8-1
We believe that the bug you reported is fixed in the latest version of
shadow, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Balint Reczey <[email protected]> (supplier of updated shadow package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Fri, 20 Dec 2019 16:39:40 +0100
Source: shadow
Binary: passwd login uidmap
Architecture: source
Version: 1:4.8-1
Distribution: unstable
Urgency: medium
Maintainer: Shadow package maintainers
<[email protected]>
Changed-By: Balint Reczey <[email protected]>
Description:
login - system login tools
passwd - change and administer password and group data
uidmap - programs to help use subuids
Closes: 808301 881889 934473
Changes:
shadow (1:4.8-1) unstable; urgency=medium
.
[ Laurent Bigonville ]
* Move the call to pam_motd before pam_selinux open
.
[ Justin B Rye ]
* login: Update package description (Closes: #808301)
.
[ Yuriy M. Kaminskiy ]
* Mark uidmap and login as Multi-Arch: foreign (Closes: #934473)
.
[ Andreas Henriksson ]
* New upstream release.
- man: generate translations using itstool instead of xml2po
* Replace gnome-doc-utils build-dep with itstool (Closes: #881889)
* Use explicit --without-su configure flag
* Refresh and massage patches to apply
* Cherry-pick upstream patch reverting bindir/sbindir
* Fix lintian warning useless-autoreconf-build-depends
.
[ Balint Reczey ]
* debian/login.su.pam: Drop unused file
Checksums-Sha1:
329313cb9c9874d278d466987cb58b5f8a490d49 2201 shadow_4.8-1.dsc
a9ef77375fabf1529d513c05ee603addc908925a 1609060 shadow_4.8.orig.tar.xz
159fcbe1a0aadccb2295182e2cb58fd07c9ca372 74780 shadow_4.8-1.debian.tar.xz
391e4d2111417e4e1effb29bb3bdcc4316666901 7736 shadow_4.8-1_source.buildinfo
Checksums-Sha256:
1878eff238725e13997042366f3d45c5a92da2cb3050c9f43afdcca00b4ccd19 2201
shadow_4.8-1.dsc
64b46683b9c1f35b2cd2da9fa87a1383917666e85a56b35e081c7257d10dac64 1609060
shadow_4.8.orig.tar.xz
7b40fb942045d97ec523725df1907eeb90b6faa365188ded76e15b439880cef7 74780
shadow_4.8-1.debian.tar.xz
83eb43a33c512f8bdb3f2cc758c3f1145d4f396ed9443967bf18ebee8bf8799f 7736
shadow_4.8-1_source.buildinfo
Files:
990cc95cd20cb0a46bbd35b08c30c631 2201 admin required shadow_4.8-1.dsc
723ebb19b06e2f52d9ed7f0653483851 1609060 admin required shadow_4.8.orig.tar.xz
4f019299e73831436fafbade87bfa629 74780 admin required
shadow_4.8-1.debian.tar.xz
a0c25dd955b763b3d4dd327f6437fca5 7736 admin required
shadow_4.8-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEI/PvTgXX55rLQUfDg6KBkWslS0UFAl3865gACgkQg6KBkWsl
S0WSHg//UR1GxTPWHAcgksJhVJ0674xd15mJP9LcJr5zX83owjmKA/F229gtDn0S
h8k/m11wFOb79Dqvez7ptZLaCsze3kMf7mCxwuQmHkm3yPkPeoSovrhp1tbWImpu
0+sxBgvmGEDvIWWNeYrwsWTQWlAkPdqZibTQQRbk/noxVVDIMKTXUJfsPRNKGMzf
NV7Z33Ok4HoBLoIQDisutoeLvndikgss6xkG1knep5gfRBhycPUejTZukKnLEh2O
Mz1ng95CBYnd3QnJjfkuvo7dqjDsYED86D7mXVe0cg+xdcA2XF8LcjEyuWBHjCsx
5W1eN9a4aTMjHDTw9z4xgSUeZntsxsjyEiMX4tyUTeMFp+Dy6JNkRxAAKjpjxpl4
8nxxLw+MXvj9R5C65guqaQ5/xjigvr1Pl7d+4u0l6znBUlAjXdeuPMuBw87l8623
YjOIvohRxp4/AuN1rq4a42LxPpyt6PisysPLmbBIuX5OddZGue5OqGAxsPxjKztA
v2GSqWQRRbLFuQPbOeAD6I9vU9p6BFMzxyjAKiF4XVXr54Wi5Aqu6DKKnCds0WZE
j4/OudX6yWyBMCnjdbKekgM+MPI/QmttavsZSOQrUyqkj6iRqwJkSNjzsHz07rEk
uy4ZcERIob1BsGN/E0hnaRQCe0bqt+3d96oAWtH/jpMRp1iojWs=
=yjcL
-----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________
Pkg-shadow-devel mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-shadow-devel
