Your message dated Tue, 02 Nov 2021 20:26:16 +0000
with message-id <[email protected]>
and subject line Bug#989712: fixed in shadow 1:4.8.1-1.1
has caused the Debian Bug report #989712,
regarding delete cruft from passwd and login maintainer scripts
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
989712: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=989712
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: shadow
Version: 1:4.8.1-1
Tags: patch
The maintainer scripts have accumulated a bit of obsolete code over
time. This code becomes problematic as we are in the process of changing
the installation bootstrap. Less code means less things we touch.
Therefore, I ask for cleaning up this code. In detail:
* The code for dealing with logoutd can be removed, because it was
already absent in buster (probably longer) and we don't support skip
upgrades.
* The creation of /etc/subuid and /etc/subgid is duplicated inside
login.postinst. Initialize only once.
* login.preinst and passwd.preinst handle upgrades from pre 1:4.0.3 and
can be deleted.
Please consider applying the attached patch.
Helmut
diff --minimal -Nru shadow-4.8.1/debian/changelog shadow-4.8.1/debian/changelog
--- shadow-4.8.1/debian/changelog 2020-02-07 15:54:14.000000000 +0100
+++ shadow-4.8.1/debian/changelog 2021-06-11 07:55:31.000000000 +0200
@@ -1,3 +1,13 @@
+shadow (1:4.8.1-1.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Remove obsolete upgrade code from maintainer scripts. (Closes: #-1)
+ + logoutd is gone since at least buster.
+ + Delete duplicate subuid/subgid creation.
+ + Delete preinsts upgrading from 1:4.0.3.
+
+ -- Helmut Grohne <[email protected]> Fri, 11 Jun 2021 07:55:31 +0200
+
shadow (1:4.8.1-1) unstable; urgency=medium
* debian/default/useradd: Fix typo DHSELL -> DSHELL (Closes: #897028)
diff --minimal -Nru shadow-4.8.1/debian/login.postinst
shadow-4.8.1/debian/login.postinst
--- shadow-4.8.1/debian/login.postinst 2020-02-07 15:54:14.000000000 +0100
+++ shadow-4.8.1/debian/login.postinst 2021-06-11 07:53:36.000000000 +0200
@@ -2,18 +2,5 @@
set -e
-if test "$1" = configure
-then
- if test -f /etc/init.d/logoutd
- then
- if test "$(md5sum /etc/init.d/logoutd)" =
"9080f92783dd53f6f2108e698c06bd53 /etc/init.d/logoutd"
- then
- echo "removing logoutd cruft"
- rm /etc/init.d/logoutd
- update-rc.d logoutd remove
- fi
- fi
-fi
-rm -f /etc/pam.d/login.pre-upgrade 2>/dev/null
if [ "$1" = "configure" ]; then
@@ -38,19 +26,6 @@
fi
fi
- # Create subuid/subgid if missing
- if [ ! -e /etc/subuid ]; then
- touch /etc/subuid
- chown root:root /etc/subuid
- chmod 644 /etc/subuid
- fi
-
- if [ ! -e /etc/subgid ]; then
- touch /etc/subgid
- chown root:root /etc/subgid
- chmod 644 /etc/subgid
- fi
-
#DEBHELPER#
exit 0
diff --minimal -Nru shadow-4.8.1/debian/login.preinst
shadow-4.8.1/debian/login.preinst
--- shadow-4.8.1/debian/login.preinst 2020-02-07 15:54:14.000000000 +0100
+++ shadow-4.8.1/debian/login.preinst 1970-01-01 01:00:00.000000000 +0100
@@ -1,52 +0,0 @@
-#! /bin/sh
-
-#
-# see: dh_installdeb(1)
-
-set -e
-
-# summary of how this script can be called:
-# * <new-preinst> `install'
-# * <new-preinst> `install' <old-version>
-# * <new-preinst> `upgrade' <old-version>
-# * <old-preinst> `abort-upgrade' <new-version>
-#
-# for details, see http://www.debian.org/doc/debian-policy/ or
-# the debian-policy package
-
-remove_md5() {
- if md5sum $1 2>/dev/null |grep -q $2; then
- cp $1 $1.pre-upgrade
- sed -e '/^[^#][ \t]*assword[ \t]*required[ \t]*pam_unix.so/ s/ md5$//'
$1 >$1.post-upgrade \
- && mv $1.post-upgrade $1
- fi
- }
-
-
-case "$1" in
- install|upgrade)
- if [ "x$2" != "x" ] ; then
- if dpkg --compare-versions $2 lt 1:4.0.3 ; then
- remove_md5 /etc/pam.d/login 5e61c3334e25625fe1fa4d79cf9123ff
- fi
- fi
-
- ;;
-
- abort-upgrade)
- ;;
-
- *)
- echo "preinst called with unknown argument \`$1'" >&2
- exit 1
- ;;
-esac
-
-# dh_installdeb will replace this with shell code automatically
-# generated by other debhelper scripts.
-
-#DEBHELPER#
-
-exit 0
-
-
diff --minimal -Nru shadow-4.8.1/debian/passwd.postinst
shadow-4.8.1/debian/passwd.postinst
--- shadow-4.8.1/debian/passwd.postinst 2020-02-07 15:54:14.000000000 +0100
+++ shadow-4.8.1/debian/passwd.postinst 2021-06-11 07:54:40.000000000 +0200
@@ -4,19 +4,5 @@
case "$1" in
configure)
- # Fix permissions on various log files from old versions of the debian
- # installer, some unrelated to passwd but we decided to put the fix
- # here since there was no better place. This can safely be removed
- # after etch is released.
- if dpkg --compare-versions "$2" lt "1:4.0.14-9"; then
- for log in /var/log/base-config* \
- $(find /var/log/debian-installer/ /var/log/installer/ -type
f 2>/dev/null ); do
- if [ -e "$log" ]; then
- chmod 600 "$log"
- fi
- done
- fi
-
- rm -f /etc/pam.d/passwd.pre-upgrade 2>/dev/null
if ! getent group shadow | grep -q '^shadow:[^:]*:42'
then
diff --minimal -Nru shadow-4.8.1/debian/passwd.preinst
shadow-4.8.1/debian/passwd.preinst
--- shadow-4.8.1/debian/passwd.preinst 2020-02-07 15:54:14.000000000 +0100
+++ shadow-4.8.1/debian/passwd.preinst 1970-01-01 01:00:00.000000000 +0100
@@ -1,51 +0,0 @@
-#! /bin/sh
-
-#
-# see: dh_installdeb(1)
-
-set -e
-
-# summary of how this script can be called:
-# * <new-preinst> `install'
-# * <new-preinst> `install' <old-version>
-# * <new-preinst> `upgrade' <old-version>
-# * <old-preinst> `abort-upgrade' <new-version>
-#
-# for details, see http://www.debian.org/doc/debian-policy/ or
-# the debian-policy package
-
-remove_md5() {
- if md5sum $1 2>/dev/null |grep -q $2; then
- cp $1 $1.pre-upgrade
- sed -e '/^[^#]*[ \t]*password[ \t]*required[ \t]*pam_unix.so/ s/
md5$//' $1 >$1.post-upgrade \
- && mv $1.post-upgrade $1
- fi
- }
-
-
-case "$1" in
- install|upgrade)
- if [ "x$2" != "x" ] ; then
- if dpkg --compare-versions $2 lt 1:4.0.3 ; then
- remove_md5 /etc/pam.d/passwd 23a5d1465bbc1e39ca6e0c32f22a75c9
- fi
- fi
- ;;
-
- abort-upgrade)
- ;;
-
- *)
- echo "preinst called with unknown argument \`$1'" >&2
- exit 1
- ;;
-esac
-
-# dh_installdeb will replace this with shell code automatically
-# generated by other debhelper scripts.
-
-#DEBHELPER#
-
-exit 0
-
-
--- End Message ---
--- Begin Message ---
Source: shadow
Source-Version: 1:4.8.1-1.1
Done: Johannes Schauer Marin Rodrigues <[email protected]>
We believe that the bug you reported is fixed in the latest version of
shadow, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Johannes Schauer Marin Rodrigues <[email protected]> (supplier of updated shadow
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sat, 23 Oct 2021 21:04:57 +0200
Source: shadow
Architecture: source
Version: 1:4.8.1-1.1
Distribution: unstable
Urgency: medium
Maintainer: Shadow package maintainers
<[email protected]>
Changed-By: Johannes Schauer Marin Rodrigues <[email protected]>
Closes: 989712 992578
Changes:
shadow (1:4.8.1-1.1) unstable; urgency=medium
.
[ Johannes Schauer Marin Rodrigues ]
* Non-maintainer upload.
.
[ Niels Thykier ]
* Remove obsolete login.preinst
* Remove obsolete code from passwd maintscripts
.
[ Helmut Grohne ]
* logoutd is gone since at least buster (closes: #989712)
* Delete duplicate subuid/subgid creation.
* login.postinstd support for DPKG_ROOT (closes: #992578)
Checksums-Sha1:
2491264464bdc2e6eec7122753f6723f8eed5420 2223 shadow_4.8.1-1.1.dsc
d1b231f725d433640cc1c11de4e9a9821515b7e2 74108 shadow_4.8.1-1.1.debian.tar.xz
7aa7d260ed62ec53b69f224342848e6581e2f238 7953 shadow_4.8.1-1.1_amd64.buildinfo
Checksums-Sha256:
026ac70bb97f30a028919d5425c1a21118c1f060080a460b3e2ab436e9410c88 2223
shadow_4.8.1-1.1.dsc
e72563343c57f19a86818ce5b8514b44f64d13b0a31354ffc21c78f5dffc596e 74108
shadow_4.8.1-1.1.debian.tar.xz
02f40d6408128d721a8c5ce16aa61c7f94d552c40e3837111c1a36c0274da4c8 7953
shadow_4.8.1-1.1_amd64.buildinfo
Files:
1941af887f7d6fbcd1666e16e4e07c32 2223 admin required shadow_4.8.1-1.1.dsc
220ae8871a89302e58ec8335bc6b1858 74108 admin required
shadow_4.8.1-1.1.debian.tar.xz
1ee0bfdb48814980066c0abf8fb2e2d8 7953 admin required
shadow_4.8.1-1.1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEElFhU6KL81LF4wVq58sulx4+9g+EFAmF0X54ACgkQ8sulx4+9
g+G2cg//QUGnQlRRK3Pu0atza+ZNmPvkac0HnOL8QbpOJf92HlJmmMkPyZ9zlM5J
/PFDkWOXVPtdZ+tFQ69zswP6RbNJNgYvCY/nasrioGw2WeNfOViz1yOYBbzmRk18
47EkclWB0wHy12iHwkDw8Wp43cKC9RyiF+/M/zbGmDFawKZ9e45y7aOU1wvGg89X
9oUuKYijKA3GYGhzgHpHfOKDQdgHq7aW/VdzK9ooimbs5G+Y0OuT+BCkgCh3Pnrg
eEWLtJQOze9OnAhujHhVi476cBUmg/kn22GWZ+4SFYAW9hYRZm5FiwlCH5G5sHSL
O460uv1S5vbGdoT2dZxFoMjDQ7YzUmWAIHqXhO5zlZmoJljAOIu2oWyT06ScKS0o
zc9+XGWy2cL/Mu26F6ettFNkqsJYdcp0DjpJCAe3dFhPaOvu9zIpx4OB5X/J/tbD
IJ4mf+L1dbpdeo0b3rW8U26bIeV/tT2XFl5OoN+PUrQsBxZ1SGlVOMzMcrLuAPTA
DHtjW7rxwqrqZJNIg0Url9UUWaEY0EWDISIrZhUL5jOOTv4QOd+1On9fye5PKoq5
w3T1bNdMhZCO2ih7qMT/6M5yPsPRL0t9RrqhGvGAF3PpuzqHhCsVxVOrD1HNC8V5
Jah6H55P/u1Lk/fYtZvGdVyCfdp7J1z9QJigGsdE+NOPdxj6/dg=
=GspR
-----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________
Pkg-shadow-devel mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-shadow-devel
