Control: tags -1 patch On Sun, 21 Jan 2018 16:45:47 +0100 Michael Biebl <[email protected]> wrote: > [...] > > See the generated postinst script. > > The more I think about these ordering issues, the more I'm convinced > that for services which ship both a native service file and a systemd > service file, we should leave the start/stop/restart of the service to > dh_installsystemd/deb-systemd-invoke and only use the invoke-rc.d call > on sysvinit systems.
I have created a patch that ensures that dh_installsystemd's snippet are used for start/stop/restart iff the system is running systemd. Otherwise, the dh_installinit version handles start/stop/restart. * I would welcome a review of this branch before I merge it, so we do not end up with another "incomplete split" like we had with compat 11. * Branch at: https://salsa.debian.org/nthykier/debhelper/tree/dh_installinit-dh_installsystemd-isolation-c12 The end goal is that dh_installinit and dh_installsystemd's snippets are completely independent and will have complete control of their own parts without having to "synchronize" with the other tool. Known issues: ============= * Documentation has not been updated (e.g. changelog, manpages and notably the "changes in compat 12"). > > [...] > > This would be a change of behaviour, so I'm not sure if this should be > in compat 11 or deferred to compat 12. But afaics, the current > dh_installsystemd in compat 11 is not actually working due to these > ordering issues which are a result of no longer having two separate > helpers which ran befor and after dh_installinit. > > -- > Why is it that all of the instruments seeking intelligent life in the > universe are pointed away from Earth? I have opted for a compat 12 change; I intend to release compat 12 as stable before buster is released. Thanks, ~Niels _______________________________________________ Pkg-systemd-maintainers mailing list [email protected] https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-systemd-maintainers
