Daniele Nicolodi: > On 6/11/18 12:04 AM, Niels Thykier wrote: >> Thanks for working in improving debhelper and particular improving its >> testsuite in the process. :) > > I'm only looking ad dh_installsystemd.
That is still improving debhelper. :) > I think the code can be improved > a bit and the test suite extended to cover more cases. What's the > preferred way to send patches? > Either merge requests in the debhelper repo on salsa (https://salsa.debian.org/debian/debhelper/) or patches attached to the BTS. The merge requests on salsa have the advantage of doing CI as a part of it so it is slightly easier for me. :) >>> [...] However, in the case of symlinks >>> execution never goes past the 'return unless -f $name' test and %aliases >>> is never populated. >>> >> >> The "-f" test returns true for any file or symlink to a file by default: > > [...] > >> The perldoc from "perldoc -f -X" is not particularly clear on this. > > Indeed, I was mislead by the perldoc entry. My tests must be failing for > some other reason then. I'll investigate further. > > Thanks. Cheers, > Dan > No worries; it is surprisingly implicitly in the documentation, so I am not surprised that you missed it. :) Thanks, ~Niels _______________________________________________ Pkg-systemd-maintainers mailing list [email protected] https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-systemd-maintainers
