Your message dated Sun, 14 Nov 2010 22:18:53 +0000
with message-id <[email protected]>
and subject line Bug#597338: fixed in sysvinit 2.88dsf-13
has caused the Debian Bug report #597338,
regarding Do not unmount virtual/kernel fs as it breaks shutdown/reboot when 
using systemd
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
597338: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=597338
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: initscripts
Version: 2.88dsf-12
Severity: normal
Tags: patch

Hi,

systemd is a new init systemd, which makes use of cgroups to track
running processes.
The cgroupfs is mounted below /sys/fs/cgroup as shown below:

$ mount | grep cgroup
tmpfs on /sys/fs/cgroup type tmpfs (rw,noexec,nosuid,nodev,relatime,mode=755)
cgroup on /sys/fs/cgroup/systemd type cgroup 
(rw,noexec,nosuid,nodev,relatime,release_agent=/lib/systemd/systemd-cgroups-agent,name=systemd)
cgroup on /sys/fs/cgroup/cpuset type cgroup 
(rw,noexec,nosuid,nodev,relatime,cpuset) 
cgroup on /sys/fs/cgroup/ns type cgroup (rw,noexec,nosuid,nodev,relatime,ns)
cgroup on /sys/fs/cgroup/cpu type cgroup (rw,noexec,nosuid,nodev,relatime,cpu)
cgroup on /sys/fs/cgroup/cpuacct type cgroup 
(rw,noexec,nosuid,nodev,relatime,cpuacct)
cgroup on /sys/fs/cgroup/devices type cgroup 
(rw,noexec,nosuid,nodev,relatime,devices)
cgroup on /sys/fs/cgroup/freezer type cgroup 
(rw,noexec,nosuid,nodev,relatime,freezer)
cgroup on /sys/fs/cgroup/net_cls type cgroup 
(rw,noexec,nosuid,nodev,relatime,net_cls)

/etc/init.d/umountfs tries to unmount those file systems on shutdown. As
systemd still uses them, it fails, which results in error messags during
reboot/shutdown.

I discussed this with Tollef (Debian systemd maintainer) and Kay Sievers
(udev and systemd upstream developer).

We came to the conclusion that virtual/kernel file systems
should not be unmounted at all, as there is no good reason to do so.
The attached patch does just that. It skips all mount points below
/sys/*

I've been using this patch for some time now without any problems.

Please consider applying it in the next upload.

Thanks,
Michael


-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-5-686 (SMP w/1 CPU core)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages initscripts depends on:
ii  coreutils                     8.5-1      GNU core utilities
ii  debianutils                   3.4        Miscellaneous utilities specific t
ii  libc6                         2.11.2-6   Embedded GNU C Library: Shared lib
ii  lsb-base                      3.2-23.1   Linux Standard Base 3.2 init scrip
ii  mount                         2.17.2-3.1 Tools for mounting and manipulatin
ii  sysv-rc                       2.88dsf-12 System-V-like runlevel change mech
ii  sysvinit-utils                2.88dsf-12 System-V-like utilities

Versions of packages initscripts recommends:
ii  e2fsprogs                     1.41.12-2  ext2/ext3/ext4 file system utiliti
ii  psmisc                        22.13-1    utilities that use the proc file s

initscripts suggests no packages.

-- Configuration Files:
/etc/init.d/reboot changed [not included]
/etc/init.d/sendsigs changed [not included]
/etc/init.d/umountfs changed [not included]

-- no debconf information
diff --git a/debian/src/initscripts/etc/init.d/umountfs b/debian/src/initscripts/etc/init.d/umountfs
index 24892d1..7df5e3f 100755
--- a/debian/src/initscripts/etc/init.d/umountfs
+++ b/debian/src/initscripts/etc/init.d/umountfs
@@ -27,7 +27,7 @@ do_stop () {
 	do
 		echo "$PROTECTED_MOUNTS" | grep -qs "^$DEV $MTPT " && continue
 		case "$MTPT" in
-		  /|/proc|/dev|/.dev|/dev/pts|/dev/shm|/dev/.static/dev|/proc/*|/sys|/lib/init/rw)
+		  /|/proc|/dev|/.dev|/dev/pts|/dev/shm|/dev/.static/dev|/proc/*|/sys|/sys/*|/lib/init/rw)
 			continue
 			;;
 		  /var/run)

--- End Message ---
--- Begin Message ---
Source: sysvinit
Source-Version: 2.88dsf-13

We believe that the bug you reported is fixed in the latest version of
sysvinit, which is due to be installed in the Debian FTP archive:

initscripts_2.88dsf-13_i386.deb
  to main/s/sysvinit/initscripts_2.88dsf-13_i386.deb
sysv-rc_2.88dsf-13_all.deb
  to main/s/sysvinit/sysv-rc_2.88dsf-13_all.deb
sysvinit-utils_2.88dsf-13_i386.deb
  to main/s/sysvinit/sysvinit-utils_2.88dsf-13_i386.deb
sysvinit_2.88dsf-13.diff.gz
  to main/s/sysvinit/sysvinit_2.88dsf-13.diff.gz
sysvinit_2.88dsf-13.dsc
  to main/s/sysvinit/sysvinit_2.88dsf-13.dsc
sysvinit_2.88dsf-13_i386.deb
  to main/s/sysvinit/sysvinit_2.88dsf-13_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Petter Reinholdtsen <[email protected]> (supplier of updated sysvinit package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 14 Nov 2010 23:08:45 +0100
Source: sysvinit
Binary: sysvinit sysvinit-utils sysv-rc initscripts
Architecture: source i386 all
Version: 2.88dsf-13
Distribution: unstable
Urgency: low
Maintainer: Debian sysvinit maintainers 
<[email protected]>
Changed-By: Petter Reinholdtsen <[email protected]>
Description: 
 initscripts - scripts for initializing and shutting down the system
 sysv-rc    - System-V-like runlevel change mechanism
 sysvinit   - System-V-like init utilities
 sysvinit-utils - System-V-like utilities
Closes: 584862 590560 594253 597338
Changes: 
 sysvinit (2.88dsf-13) unstable; urgency=low
 .
   [ Kel Modderman ]
   * Remove runlevel duration printing code from init.d/rc script
     as it was scheduled for removal before squeeze and imperfect.
     (Closes: #584862)
   * Prevent init.d/rc script from executing stop scripts twice
     in runlevels 0 and 6 when conccurrent boot is enabled.
     (Closes: #594253)
   * Modify debian/startpar/patches/06_stdin_notty.patch so it applies
     without fuzziness.
   * Add debian/startpar/patches/08_kfreebsd_proc_error_debug.patch to
     prevent frequent messages on Debian GNU/kFreeBSD from littering boot
     messages. Thanks Petr Salinger for the patch. (Closes: #590560)
   * Avoid umounting virtual filesystems (eg, cgroup) mounted under
     /sys/* as there is no good reason to do so. Thanks Michael Biebl
     for the patch. (Closes: #597338)
 .
   [ Petter Reinholdtsen ]
   * Update Standards-Version from 3.8.4 to 3.9.1.  No changes needed.
Checksums-Sha1: 
 772ce56118b4a57e84b1e2525423159ef43fc139 1511 sysvinit_2.88dsf-13.dsc
 6351cc262c46ed040c7fd3fa27d216b5f91f5345 166664 sysvinit_2.88dsf-13.diff.gz
 98e6b45400dbc631a1c82484c538e55d567e7aac 115444 sysvinit_2.88dsf-13_i386.deb
 c7e13b94dc4288984c921b155885c58930646040 115994 
sysvinit-utils_2.88dsf-13_i386.deb
 e9f7c0f51a9acdbadbe3e07a475c3da30745ff4e 68738 initscripts_2.88dsf-13_i386.deb
 7a7097ff204c5239fe8de393b736f1a8d8849a6f 73762 sysv-rc_2.88dsf-13_all.deb
Checksums-Sha256: 
 bfc3a80e2d82849061b104fc3b937dbc43252d2b73c448b5fc2315a51739ebd2 1511 
sysvinit_2.88dsf-13.dsc
 963b60103387d15643ecab5b10ea4bac28118cc3762b8410feb5d6a54bf668d6 166664 
sysvinit_2.88dsf-13.diff.gz
 ab7ff1a0a10d0e789c1e9f4a337f51fc9eb01c53853075f131e8e8c41d60d9bb 115444 
sysvinit_2.88dsf-13_i386.deb
 7930f116692b05b0d5de385d841072ca3dc10bf3072a9866d8d4b944777d9b76 115994 
sysvinit-utils_2.88dsf-13_i386.deb
 2ac0c7bc99fa71cbf40a07b32a9a0939a661a7c4f4ad3acd6367670b26e93436 68738 
initscripts_2.88dsf-13_i386.deb
 04cd910e81a24c14c9333054bdf5fc456415d46cf93fc0cdef1dea518a88cebd 73762 
sysv-rc_2.88dsf-13_all.deb
Files: 
 7a327c41f07caefd48282e54ca6ca0c5 1511 admin required sysvinit_2.88dsf-13.dsc
 838b5e93e4d91c3a2f399608e893c210 166664 admin required 
sysvinit_2.88dsf-13.diff.gz
 a8ef10ae28691b73d92453bd671770ac 115444 admin required 
sysvinit_2.88dsf-13_i386.deb
 7254cdfe39c60f07b3760b9177438443 115994 admin required 
sysvinit-utils_2.88dsf-13_i386.deb
 f9ef015c00147a7f02cacbffc6e5a2d7 68738 admin required 
initscripts_2.88dsf-13_i386.deb
 3e1fec53b494ba4c19d3dd311d672c2e 73762 admin required 
sysv-rc_2.88dsf-13_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFM4F7120zMSyow1ykRAm6kAKDq2iGeEIEM2B3OxS4ElH6pU9Zk2gCfbV+W
eKv6cAm7PXDCJDXrLzN6ZHw=
=1tEE
-----END PGP SIGNATURE-----



--- End Message ---
_______________________________________________
Pkg-sysvinit-devel mailing list
[email protected]
http://lists.alioth.debian.org/mailman/listinfo/pkg-sysvinit-devel

Reply via email to