On Fri, Jun 29, 2012 at 08:27:22PM +0100, Roger Leigh wrote: > The following patch implements this behaviour. While the insserv > parsing logic has been tested, it's not been tested for upgrades > or whether the whole script works correctly. > > - it needs a Depends on insserv (>= $version_with_-s) > ==> this needs your feedback so it can be uploaded. > - the preinst could be simplified to just use > update-rc.d "$script" -f defaults > if this is sufficient to update the sequence numbers in the > configuration. This probably needs running in the postinst TBH. > - this just replaces the defaults and user-provided start and stop > arguments with those provided by insserv. Other than that, there > are no changes to anything else. > - You might need to retain support for the old-style logic so that > if other scripts call update-rc.d in the gap between unpacking and > running the postinst, it won't fail. Just back out the deletions > and run those blocks only if insserv didn't run or didn't find any > matches, which are a trivial addition to the script. > > While this patch is just a proof a concept, this should be pretty much > all you need. It just needs checking and testing by someone with > file-rc expertise. If this could be done in the very near future, > then that would be great.
I've attached an updated patch. This patch - Retains the old pre-insserv logic, and falls back to it if insserv is not available, or if insserv fails to find the script. This is to aid the transition (between the new file-rc being configured and the postinst being run to migrate all the scripts), and should be removed in wheezy+1. - Adds extra safeguards around the insserv logic, so it's only run if insserv is available. - Moves the migration from the preinst to the postinst, since insserv is only available in the postinst. - Still requires a package dependency on the fixed version of insserv. Hope this is OK. Still needs testing, BTW. I'll take a look at that tomorrow, time permitting. Regards, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linux http://people.debian.org/~rleigh/ `. `' schroot and sbuild http://alioth.debian.org/projects/buildd-tools `- GPG Public Key F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800 _______________________________________________ Pkg-sysvinit-devel mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-sysvinit-devel
