Hello Michael, On 29/05/2018 09:30, Michael Biebl wrote: > I had a short look at the package
Thank you very much. > a/ a hard dep on systemd-sysv. Is dbus-broker strictly systemd-only? The > launcher part probably is, but the messaging part should be init system > agnostic? Would it be possible that a launcher for sysvinit could > replace the systemd specific launcher? Should this be reflected in the > packaging by splitting of the launcher part? > If this is not possible and not intended, then it might possibly be a > good idea to document somewhere why dbus-broker is systemd-only. dbus-broker depends on systemd for launching bus activated services. I thought about splitting the launcher and the message broker parts, but upstream does not yet consider the interface between the two components stable thus I decided to postpone splitting the two components. I'll add the reason for the systemd dependency to README.Debian. > b/ /etc/systemd/user/dbus.service -> > /usr/lib/systemd/user/dbus-broker.service symlink > > I know that systemd user services currently are not yet supported by > init-system-helpers. Shipping a symlink in /etc in the package is > semi-optimal though. Afair, symlinks are not treated like real conffiles > and are re-created on package upgrades. So if an admin disables the user > part of dbus-broker, it will be re-enabled, so you might just as well > ship the symlink in /usr/lib/systemd/user. I debated what to do for a while, and I decided to enable the user service by default because I imagined that this was most likely what was expected. I didn't add the symlink in /usr/lib/systemd/user to do not conflict with the dbus package, which is required by dbus-broker for the dbus utilities and for the bus policy. There is a little explanation in README.Debian. > The alternative is to ship the user part not-enabled by default and > document that this needs to be enabled manually. I will revert this and put back the instructions to enable the user service in README.Debian. What would it take to have user services managed in a similar way as system services? Should I look into implementing that in init-system-helpers or should a new dh helper be created? Thanks for your review. Cheers, Dan _______________________________________________ Pkg-utopia-maintainers mailing list Pkg-utopia-maintainers@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-utopia-maintainers
