Your message dated Mon, 21 Dec 2020 07:45:31 +0100
with message-id <[email protected]>
and subject line Re: Bug#949595: cockpit: Please include patch to fix build on 
sparc64
has caused the Debian Bug report #949595,
regarding cockpit: Please include patch to fix build on sparc64
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
949595: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=949595
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: cockpit
Severity: normal
Tags: patch upstream
User: [email protected]
Usertags: sparc64

Hi!

cockpit FTBFS on sparc64 due to unaligned access. The attached package fixes
it. I have also forwarded the issue upstream [1].

Adrian

> [1] https://github.com/cockpit-project/cockpit/pull/13435

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - [email protected]
`. `'   Freie Universitaet Berlin - [email protected]
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
Description: websocket: Fix unaligned access in send_prefixed_message_rfc6455()
 Fixes the build on sparc64.
 .
Author: John Paul Adrian Glaubitz <[email protected]>
Forwarded: https://github.com/cockpit-project/cockpit/pull/13435
Last-Update: 2020-01-22

Index: cockpit-210/src/websocket/websocketconnection.c
===================================================================
--- cockpit-210.orig/src/websocket/websocketconnection.c
+++ cockpit-210/src/websocket/websocketconnection.c
@@ -430,9 +430,10 @@ send_prefixed_message_rfc6455 (WebSocket
    */
   if (!self->pv->server_side)
     {
+      guint32 rand = g_random_int ();
       outer[1] |= 0x80;
       mask = outer + bytes->len;
-      * ((guint32 *)mask) = g_random_int ();
+      memcpy (mask, &rand, sizeof(guint8));
       bytes->len += 4;
     }
 

--- End Message ---
--- Begin Message ---
Version: 212-1

Martin Pitt [2020-01-24 11:34 +0100]:
> Thanks a lot Adrian for tracking this down! The fix landed upstream and thus
> will be part of 212.

Whoops, I forgot to close this back then.

Martin

--- End Message ---
_______________________________________________
Pkg-utopia-maintainers mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-utopia-maintainers

Reply via email to