Your message dated Sun, 14 Jan 2007 21:31:21 +0100
with message-id <[EMAIL PROTECTED]>
and subject line Closing #401672
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: thunar
Version: 0.4.0rc1-2
Severity: important
Tags: patch
Hi,
thunar fails to build on hurd-i386:
Automatic build of thunar_0.4.0rc1-2 on beethoven by sbuild/hurd-i386 85
Build started at 20061204-2007
******************************************************************************
[...]
Checking correctness of source dependencies...
Toolchain package versions: libc0.3-dev_2.3.6.ds1-5 gcc-4.1_4.1.1-20
g++-4.1_4.1.1-20 binutils_2.17-3 libstdc++6-4.1-dev_4.1.1-20
libstdc++6_4.1.1-20
Start building
------------------------------------------------------------------------------
gpg: Signature made Fri Sep 29 14:33:09 2006 CEST using DSA key ID DF5CE2B4
gpg: Can't check signature: public key not found
dpkg-source: extracting thunar in thunar-0.4.0rc1
dpkg-source: unpacking thunar_0.4.0rc1.orig.tar.gz
dpkg-source: applying /org/buildd/build/thunar_0.4.0rc1-2.diff.gz
dpkg-buildpackage: source package is thunar
dpkg-buildpackage: source version is 0.4.0rc1-2
dpkg-buildpackage: host architecture hurd-i386
dpkg-buildpackage: source version without epoch 0.4.0rc1-2
[...]
debian/rules build
[...]
cc -DHAVE_CONFIG_H -I. -I. -I.. -I.. -DEXO_API_SUBJECT_TO_CHANGE
-DEXO_DISABLE_DEPRECATED -DG_LOG_DOMAIN=\"thunar-vfs\"
-DLIBEXECDIR=\"/usr/lib/thunar\" -DSN_API_NOT_YET_FROZEN
-DTHUNAR_VFS_COMPILATION -DTHUNAR_VFS_VERSION_API=\"1\" -NDEBUG
-DG_DISABLE_CAST_CHECKS -DHAVE_GNUC_VISIBILITY -I/usr/include/exo-0.3
-I/usr/include/gtk-2.0 -I/usr/include/xfce4 -I/usr/lib/gtk-2.0/include
-I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2
-I/usr/include/libpng12 -D_REENTRANT -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -I/usr/include/fam -I/usr/include/libpng12
-I/usr/include/startup-notification-1.0 -g -Wall -O2 -c thunar-vfs-io-local.c
-fPIC -DPIC -o .libs/libthunar_vfs_1_la-thunar-vfs-io-local.o
cc: unrecognized option '-NDEBUG'
thunar-vfs-io-local.c: In function '_thunar_vfs_io_local_rename':
thunar-vfs-io-local.c:840: error: 'PATH_MAX' undeclared (first use in this
function)
thunar-vfs-io-local.c:840: error: (Each undeclared identifier is reported only
once
thunar-vfs-io-local.c:840: error: for each function it appears in.)
thunar-vfs-io-local.c:840: warning: unused variable 'src_path'
make[4]: *** [libthunar_vfs_1_la-thunar-vfs-io-local.lo] Error 1
make[4]: Leaving directory `/build/buildd/thunar-0.4.0rc1/thunar-vfs'
PATH_MAX is not defined on GNU/Hurd, as no limit exists. Thunar uses
THUNAR_VFS_PATH_MAXSTRLEN in all other similar situation AFAICT, so just
using it here (it gets defined to PATH_MAX on systems which have it
anyway) seems like a straight-forward fix to me, patch attached.
cheers,
Michael
--- thunar-0.4.0rc1/thunar-vfs/thunar-vfs-io-local.c.orig 2006-12-04
20:32:29.000000000 +0100
+++ thunar-0.4.0rc1/thunar-vfs/thunar-vfs-io-local.c 2006-12-04
20:32:48.000000000 +0100
@@ -837,7 +837,7 @@
gsize data_length;
gchar *data;
gchar *key;
- gchar src_path[PATH_MAX + 1];
+ gchar src_path[THUNAR_VFS_PATH_MAXSTRLEN];
gchar *dir_name;
gchar *dst_name;
gchar *dst_path;
--- End Message ---
--- Begin Message ---
Version: 0.5.0rc2-1
Hi,
this version of the thunar package built fine on an Hurd box. Thanks!
Cheers,
--
Cyril Brulebois
pgpElkbqhSvy8.pgp
Description: PGP signature
--- End Message ---
_______________________________________________
Pkg-xfce-devel mailing list
Pkg-xfce-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-xfce-devel
