Your message dated Wed, 12 Dec 2007 23:17:04 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#455866: fixed in thunar 0.9.0-2
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message ---
Package: xfdesktop4
Version: 4.4.2-1scorpi0
Severity: normal
Tags: patch
Hi,
in the fix for http://bugzilla.xfce.org/show_bug.cgi?id=3119, Benedikt added
a function thunar_vfs_volume_is_ejectable(), so that Thunar can show an
"Eject" in the context menu of volumes that support eject. However,
xfdesktop4 only enables this if thunar_vfs_volume_is_disc() returns true, so
"Eject" is only shown for optical discs.
I attach 2 patches, both of them fix this bug. One is a minimal patch to add
"Eject" to the menu, and another patch that also makes the menu consistent
with Thunar (see
http://foo-projects.org/pipermail/thunar-dev/2007-December/004298.html and
the following mails).
Regards,
Tino
-- System Information:
Debian Release: lenny/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.23.8 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages xfdesktop4 depends on:
ii libatk1.0-0 1.20.0-1 The ATK accessibility toolkit
ii libc6 2.7-4 GNU C Library: Shared libraries
ii libcairo2 1.4.10-1.2 The Cairo 2D vector graphics libra
ii libdbus-1-3 1.1.2-1 simple interprocess messaging syst
ii libdbus-glib-1-2 0.74-1 simple interprocess messaging syst
ii libexo-0.3-0 0.3.4-1 Library with extensions for Xfce
ii libfontconfig1 2.5.0-2 generic font configuration library
ii libfreetype6 2.3.5-1+b1 FreeType 2 font engine, shared lib
ii libglib2.0-0 2.14.4-2 The GLib library of C routines
ii libgtk2.0-0 2.12.3-1 The GTK+ graphical user interface
ii libice6 2:1.0.4-1 X11 Inter-Client Exchange library
ii libpango1.0-0 1.18.3-1 Layout and rendering of internatio
ii libpng12-0 1.2.15~beta5-3 PNG library - runtime
ii libsm6 2:1.0.3-1+b1 X11 Session Management library
ii libthunar-vfs-1-2 0.9.0-1scorpi0 VFS abstraction used in thunar
ii libx11-6 2:1.0.3-7 X11 client-side library
ii libxfce4mcs-client3 4.4.2-1 Client library for Xfce4 configure
ii libxfce4util4 4.4.2-1 Utility functions library for Xfce
ii libxfcegui4-4 4.4.2-1 Basic GUI C functions for Xfce4
ii libxrender1 1:0.9.4-1 X Rendering Extension client libra
ii xfce4-mcs-manager 4.4.2-1 Settings manager for Xfce4
ii xfce4-panel 4.4.2-1 The Xfce4 desktop environment pane
ii xfce4-utils 4.4.2-3 Various tools for Xfce
ii xfdesktop4-data 4.4.2-1scorpi0 Provides xfdesktop4 desktop backgr
ii zlib1g 1:1.2.3.3.dfsg-7 compression library - runtime
Versions of packages xfdesktop4 recommends:
ii dbus 1.1.2-1 simple interprocess messaging syst
ii librsvg2-common 2.18.2-1 SAX-based renderer library for SVG
-- debconf-show failed
diff -ru xfdesktop4-4.4.2.orig/src/xfdesktop-volume-icon.c
xfdesktop4-4.4.2/src/xfdesktop-volume-icon.c
--- xfdesktop4-4.4.2.orig/src/xfdesktop-volume-icon.c 2007-11-17
20:31:41.000000000 +0100
+++ xfdesktop4-4.4.2/src/xfdesktop-volume-icon.c 2007-12-11
22:14:46.005592273 +0100
@@ -573,8 +573,7 @@
icon);
}
- if(thunar_vfs_volume_is_disc(volume)
- && thunar_vfs_volume_is_ejectable(volume))
+ if(thunar_vfs_volume_is_ejectable(volume))
{
mi = gtk_image_menu_item_new_with_mnemonic(_("E_ject Volume"));
gtk_widget_show(mi);
diff -ru xfdesktop4-4.4.2.orig/src/xfdesktop-volume-icon.c
xfdesktop4-4.4.2/src/xfdesktop-volume-icon.c
--- xfdesktop4-4.4.2.orig/src/xfdesktop-volume-icon.c 2007-11-17
20:31:41.000000000 +0100
+++ xfdesktop4-4.4.2/src/xfdesktop-volume-icon.c 2007-12-12
01:07:27.421327344 +0100
@@ -562,19 +562,7 @@
icon);
}
- mi = gtk_image_menu_item_new_with_mnemonic(_("_Unmount Volume"));
- gtk_widget_show(mi);
- gtk_menu_shell_append(GTK_MENU_SHELL(menu), mi);
- if(!thunar_vfs_volume_is_mounted(volume))
- gtk_widget_set_sensitive(mi, FALSE);
- else {
- g_signal_connect(G_OBJECT(mi), "activate",
- G_CALLBACK(xfdesktop_volume_icon_menu_toggle_mount),
- icon);
- }
-
- if(thunar_vfs_volume_is_disc(volume)
- && thunar_vfs_volume_is_ejectable(volume))
+ if(thunar_vfs_volume_is_ejectable(volume))
{
mi = gtk_image_menu_item_new_with_mnemonic(_("E_ject Volume"));
gtk_widget_show(mi);
@@ -582,6 +570,17 @@
g_signal_connect(G_OBJECT(mi), "activate",
G_CALLBACK(xfdesktop_volume_icon_menu_eject),
icon);
+ } else {
+ mi = gtk_image_menu_item_new_with_mnemonic(_("_Unmount Volume"));
+ gtk_widget_show(mi);
+ gtk_menu_shell_append(GTK_MENU_SHELL(menu), mi);
+ if(!thunar_vfs_volume_is_mounted(volume))
+ gtk_widget_set_sensitive(mi, FALSE);
+ else {
+ g_signal_connect(G_OBJECT(mi), "activate",
+
G_CALLBACK(xfdesktop_volume_icon_menu_toggle_mount),
+ icon);
+ }
}
mi = gtk_separator_menu_item_new();
--- End Message ---
--- Begin Message ---
Source: thunar
Source-Version: 0.9.0-2
We believe that the bug you reported is fixed in the latest version of
thunar, which is due to be installed in the Debian FTP archive:
libthunar-vfs-1-2_0.9.0-2_amd64.deb
to pool/main/t/thunar/libthunar-vfs-1-2_0.9.0-2_amd64.deb
libthunar-vfs-1-dev_0.9.0-2_amd64.deb
to pool/main/t/thunar/libthunar-vfs-1-dev_0.9.0-2_amd64.deb
thunar-data_0.9.0-2_all.deb
to pool/main/t/thunar/thunar-data_0.9.0-2_all.deb
thunar_0.9.0-2.diff.gz
to pool/main/t/thunar/thunar_0.9.0-2.diff.gz
thunar_0.9.0-2.dsc
to pool/main/t/thunar/thunar_0.9.0-2.dsc
thunar_0.9.0-2_amd64.deb
to pool/main/t/thunar/thunar_0.9.0-2_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Yves-Alexis Perez <[EMAIL PROTECTED]> (supplier of updated thunar package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Wed, 12 Dec 2007 23:55:13 +0100
Source: thunar
Binary: libthunar-vfs-1-2 libthunar-vfs-1-dev thunar-data thunar
Architecture: source all amd64
Version: 0.9.0-2
Distribution: unstable
Urgency: low
Maintainer: Debian Xfce Maintainers <[email protected]>
Changed-By: Yves-Alexis Perez <[EMAIL PROTECTED]>
Description:
libthunar-vfs-1-2 - VFS abstraction used in thunar
libthunar-vfs-1-dev - Development files for libthunar-vfs
thunar - File Manager for Xfce
thunar-data - Provides thunar documentation, icons and translations
Closes: 455866
Changes:
thunar (0.9.0-2) unstable; urgency=low
.
* debian/control:
- explicitely enable options for ./configure.
- update standard versions.
* debian/patches:
- 03_use-eject-where-necessary added, taken from upstream. closes: #455866
* debian/copyright: remove complete GFDL text and add a link to
common-licenses.
Files:
ebcfdd39f460cc34deb5e8e6208706a9 1279 x11 optional thunar_0.9.0-2.dsc
0d2c1235866b2664e64b8dd92d601be0 7171 x11 optional thunar_0.9.0-2.diff.gz
3701ec6dc9dedb9b0086e8c370dd5795 5737526 x11 optional
thunar-data_0.9.0-2_all.deb
dac3d6ee8e8f31896493a4fadd6c11ce 18498 libdevel optional
libthunar-vfs-1-dev_0.9.0-2_amd64.deb
9b85487c8da26ed57845219ff462825b 164112 libs optional
libthunar-vfs-1-2_0.9.0-2_amd64.deb
8bf231579fc3030bf534f998d235ad72 238062 x11 optional thunar_0.9.0-2_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFHYGoTTUTAIMXAW64RAlpNAKCayqIIi0S+WgLaNgTlndSxs8M36wCfUxEY
2T2G90XclJE1Tg6iZPJrTQc=
=A8Dl
-----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________
Pkg-xfce-devel mailing list
[email protected]
http://lists.alioth.debian.org/mailman/listinfo/pkg-xfce-devel
