Your message dated Wed, 12 May 2010 08:23:06 +0200
with message-id <1273645386.2374.5.ca...@hidalgo>
and subject line Re: [Pkg-xfce-devel] Bug#480209: Bug#480209: Bug#480209: Use
HAL preferred mount point
has caused the Debian Bug report #480209,
regarding Use HAL preferred mount point
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
480209: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=480209
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: exo
Version: 0.3.4-6
Severity: wishlist
Tags: patch
While working at a customization here at O.S. Systems, we came up with
the attached patch that adds support to exo to consult HAL about the
preferred mount point that could be defined using a policy.
I think this is a nice improvement and would be nice to get it up to
upstream and add it there too if possible.
TIA,
-- System Information:
Debian Release: lenny/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.24-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=pt_BR.UTF-8, LC_CTYPE=pt_BR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Index: exo-0.3.4/exo-mount/exo-mount-hal.c
===================================================================
--- exo-0.3.4.orig/exo-mount/exo-mount-hal.c 2008-05-08 15:34:02.000000000 -0300
+++ exo-0.3.4/exo-mount/exo-mount-hal.c 2008-05-08 15:34:26.000000000 -0300
@@ -708,13 +708,32 @@
}
}
+ char *hal_mount_point;
+
/* try to determine a usable mount point */
if (G_LIKELY (device->volume != NULL))
{
- /* maybe we can use the volume's label... */
- mount_point = (gchar *) libhal_volume_get_label (device->volume);
+ const char *drive_udi = libhal_volume_get_storage_device_udi (device->volume);
+
+ if (device->drive != NULL)
+ {
+ hal_mount_point = libhal_device_get_property_string (hal_context, device->drive, "storage.policy.desired_mount_point", NULL);
+ if (hal_mount_point != NULL)
+ {
+ mount_point = g_strdup (hal_mount_point);
+ libhal_free_string(hal_mount_point);
+ }
+ }
}
- else
+
+ hal_mount_point = libhal_device_get_property_string (hal_context, libhal_volume_get_udi (device->volume), "volume.policy.desired_mount_point", NULL);
+ if (hal_mount_point != NULL)
+ {
+ mount_point = g_strdup (hal_mount_point);
+ libhal_free_string(hal_mount_point);
+ }
+
+ if (mount_point == NULL)
{
/* maybe we can use the the textual type... */
mount_point = (gchar *) libhal_drive_get_type_textual (device->drive);
--- End Message ---
--- Begin Message ---
On ven., 2009-11-06 at 09:56 -0200, Otavio Salvador wrote:
> Hello,
>
> On Fri, Nov 6, 2009 at 5:02 AM, Yves-Alexis Perez <[email protected]> wrote:
> > Ok, in fact I can't even add you to the bug CC: so please at least
> > register an account and add you to
> > http://bugzilla.xfce.org/show_bug.cgi?id=5953 or there's no chance at
> > all this patch is applied without any comment.
>
> So I did; thanks by working on it.
Ok, in fact the bug wasn't at all about exo, so there's no point if
keeping this bug open.
If you think it still makes sense, please explain why and provide
refreshed patches against exo (preferably on upstream bugzilla).
Cheers,
--
Yves-Alexis
signature.asc
Description: This is a digitally signed message part
--- End Message ---
_______________________________________________
Pkg-xfce-devel mailing list
[email protected]
http://lists.alioth.debian.org/mailman/listinfo/pkg-xfce-devel
