Your message dated Fri, 13 Apr 2012 19:07:09 +0000 with message-id <[email protected]> and subject line Bug#552765: fixed in xfce4-wavelan-plugin 0.5.10-1 has caused the Debian Bug report #552765, regarding xfce4-wavelan-plugin: Please provide an option to disable the icon to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 552765: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=552765 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: xfce4-wavelan-plugin Version: 0.5.5-3-1 Severity: wishlist Tags: patch The icon has no particular purpose, but occupies space at the taskbar. An option to disable the icon (so that only the bar graph is shown) would be nice, beause there are devices where screen space is a very limited ressource (e.g. so called "netbooks"). Below is a patch that provides that option. But it is not meant for inclusion, because it takes a xfce4-panel -r to respect the toggled option. 03_show_icon.patch --- panel-plugin/wavelan.c.orig 2009-10-26 23:11:23.529360906 +0100 +++ panel-plugin/wavelan.c 2009-10-26 23:06:53.336054344 +0100 @@ -54,6 +54,7 @@ gboolean autohide; gboolean autohide_missing; gboolean signal_colors; + gboolean show_icon; int size; GtkOrientation orientation; @@ -258,6 +259,7 @@ wavelan->autohide = xfce_rc_read_bool_entry (rc, "Autohide", FALSE); wavelan->autohide_missing = xfce_rc_read_bool_entry(rc, "AutohideMissing", FALSE); wavelan->signal_colors = xfce_rc_read_bool_entry(rc, "SignalColors", FALSE); + wavelan->show_icon = xfce_rc_read_bool_entry(rc, "ShowIcon", FALSE); } } @@ -285,6 +287,8 @@ wavelan->signal_colors = TRUE; + wavelan->show_icon = TRUE; + wavelan->plugin = plugin; wavelan->size = xfce_panel_plugin_get_size (plugin); @@ -313,10 +317,15 @@ gtk_widget_set_size_request(wavelan->signal, -1, 8); } - wavelan->image = gtk_image_new(); - gtk_image_set_from_pixbuf(GTK_IMAGE(wavelan->image), gtk_icon_theme_load_icon(gtk_icon_theme_get_default(), "network-wireless", wavelan->size-6, 0, NULL)); + wavelan_read_config(plugin, wavelan); + + /* load image */ + if (wavelan->show_icon == TRUE){ + wavelan->image = gtk_image_new(); + gtk_image_set_from_pixbuf(GTK_IMAGE(wavelan->image), gtk_icon_theme_load_icon(gtk_icon_theme_get_default(), "network-wireless", wavelan->size-6, 0, NULL)); + gtk_box_pack_start(GTK_BOX(wavelan->box), GTK_WIDGET(wavelan->image), FALSE, FALSE, 2); + } - gtk_box_pack_start(GTK_BOX(wavelan->box), GTK_WIDGET(wavelan->image), FALSE, FALSE, 2); gtk_box_pack_start(GTK_BOX(wavelan->box), GTK_WIDGET(wavelan->signal), FALSE, FALSE, 2); gtk_widget_show_all(wavelan->box); @@ -326,8 +335,6 @@ gtk_widget_set_size_request(wavelan->ebox, -1, wavelan->size); else gtk_widget_set_size_request(wavelan->ebox, wavelan->size, -1); - - wavelan_read_config(plugin, wavelan); wavelan_set_state(wavelan, wavelan->state); @@ -378,6 +385,7 @@ xfce_rc_write_bool_entry (rc, "Autohide", wavelan->autohide); xfce_rc_write_bool_entry (rc, "AutohideMissing", wavelan->autohide_missing); xfce_rc_write_bool_entry (rc, "SignalColors", wavelan->signal_colors); + xfce_rc_write_bool_entry (rc, "ShowIcon", wavelan->show_icon); xfce_rc_close(rc); @@ -404,7 +412,10 @@ wavelan_set_size(t_wavelan *wavelan, int size) { wavelan->size = size; - gtk_image_set_from_pixbuf(GTK_IMAGE(wavelan->image), gtk_icon_theme_load_icon(gtk_icon_theme_get_default(), "network-wireless", wavelan->size-6, 0, NULL)); + if (wavelan->show_icon == TRUE){ + gtk_image_set_from_pixbuf(GTK_IMAGE(wavelan->image), gtk_icon_theme_load_icon(gtk_icon_theme_get_default(), "network-wireless", wavelan->size-6, 0, NULL)); + } + if (wavelan->orientation == GTK_ORIENTATION_HORIZONTAL) gtk_widget_set_size_request(wavelan->ebox, -1, wavelan->size); else @@ -448,6 +459,15 @@ wavelan_set_state(wavelan, wavelan->state); } +/* show icon callback */ +static void +show_icon_changed(GtkToggleButton *button, t_wavelan *wavelan) +{ + TRACE ("Entered show_icon_changed"); + wavelan->show_icon = gtk_toggle_button_get_active(button); + wavelan_set_state(wavelan, wavelan->state); +} + static void wavelan_dialog_response (GtkWidget *dlg, int response, t_wavelan *wavelan) { @@ -464,7 +484,7 @@ { GtkWidget *dlg, *hbox, *label, *interface, *vbox, *autohide; GtkWidget *autohide_missing, *header, *warn_label, *signal_colors; - GtkWidget *combo; + GtkWidget *combo, *show_icon; GList *interfaces, *lp; TRACE ("Entered wavelan_create_options"); @@ -561,6 +581,17 @@ gtk_box_pack_start(GTK_BOX(hbox), signal_colors, TRUE, TRUE, 1); gtk_box_pack_start(GTK_BOX(vbox), hbox, FALSE, FALSE, 1); + hbox = gtk_hbox_new(FALSE, 2); + gtk_widget_show(hbox); + show_icon = gtk_check_button_new_with_label(_("Show icon")); + gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(show_icon), + wavelan->show_icon); + g_signal_connect(show_icon, "toggled", + G_CALLBACK(show_icon_changed), wavelan); + gtk_widget_show(show_icon); + gtk_box_pack_start(GTK_BOX(hbox), show_icon, TRUE, TRUE, 1); + gtk_box_pack_start(GTK_BOX(vbox), hbox, FALSE, FALSE, 1); + for (lp = interfaces; lp != NULL; lp = lp ->next) g_free (lp->data); g_list_free (interfaces); @@ -569,6 +600,7 @@ } + static void wavelan_orientation_changed (XfcePanelPlugin *plugin, GtkOrientation orientation,
--- End Message ---
--- Begin Message ---Source: xfce4-wavelan-plugin Source-Version: 0.5.10-1 We believe that the bug you reported is fixed in the latest version of xfce4-wavelan-plugin, which is due to be installed in the Debian FTP archive: xfce4-wavelan-plugin_0.5.10-1.debian.tar.gz to main/x/xfce4-wavelan-plugin/xfce4-wavelan-plugin_0.5.10-1.debian.tar.gz xfce4-wavelan-plugin_0.5.10-1.dsc to main/x/xfce4-wavelan-plugin/xfce4-wavelan-plugin_0.5.10-1.dsc xfce4-wavelan-plugin_0.5.10-1_amd64.deb to main/x/xfce4-wavelan-plugin/xfce4-wavelan-plugin_0.5.10-1_amd64.deb xfce4-wavelan-plugin_0.5.10.orig.tar.bz2 to main/x/xfce4-wavelan-plugin/xfce4-wavelan-plugin_0.5.10.orig.tar.bz2 A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Yves-Alexis Perez <[email protected]> (supplier of updated xfce4-wavelan-plugin package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Fri, 13 Apr 2012 20:56:15 +0200 Source: xfce4-wavelan-plugin Binary: xfce4-wavelan-plugin Architecture: source amd64 Version: 0.5.10-1 Distribution: unstable Urgency: low Maintainer: Debian Xfce Maintainers <[email protected]> Changed-By: Yves-Alexis Perez <[email protected]> Description: xfce4-wavelan-plugin - wavelan status plugin for the Xfce4 panel Closes: 552765 Changes: xfce4-wavelan-plugin (0.5.10-1) unstable; urgency=low . * New upstream release. - add a way to disable the icon. closes: #552765 Checksums-Sha1: 95d24c7440e58216ee53ab1773647931d3d8eab0 2216 xfce4-wavelan-plugin_0.5.10-1.dsc fb612f97e96eb7b4ed21cb88487aa69ada43e371 292462 xfce4-wavelan-plugin_0.5.10.orig.tar.bz2 8c840c011fca5840b0e69e2b089c7fbca37df859 3748 xfce4-wavelan-plugin_0.5.10-1.debian.tar.gz e013a7807923c64bb27d77e452afecf823d45a6c 47820 xfce4-wavelan-plugin_0.5.10-1_amd64.deb Checksums-Sha256: 114927e2b0d41cff4fe11beffd75a001d885b9b74548504192dec1bb6ffc8594 2216 xfce4-wavelan-plugin_0.5.10-1.dsc c5b2535b9c90d3fbf6a5f94d096fbc9cb5ce85e2c5d67df933f6fe74ae6f761d 292462 xfce4-wavelan-plugin_0.5.10.orig.tar.bz2 131a178f94a9ea31f3a845cefbe62038875f2b08febc2c30402dc6924ce48a38 3748 xfce4-wavelan-plugin_0.5.10-1.debian.tar.gz 9ab85e32aad62912770cace036b00d4c7d5f80e84956318181fd6aefb3d52f01 47820 xfce4-wavelan-plugin_0.5.10-1_amd64.deb Files: 08378e3b82329e4c03124852a48ff9d4 2216 xfce optional xfce4-wavelan-plugin_0.5.10-1.dsc a4cd20ef471123936e762a139f1025e1 292462 xfce optional xfce4-wavelan-plugin_0.5.10.orig.tar.bz2 6499b5c71ba78e60fe8548113c176dc3 3748 xfce optional xfce4-wavelan-plugin_0.5.10-1.debian.tar.gz f86e7d7fa5cb18ecb83e9a424fefaaaf 47820 xfce optional xfce4-wavelan-plugin_0.5.10-1_amd64.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBCgAGBQJPiHdyAAoJEDBVD3hx7wuoABsP/iwCQqjbrbKGiE1HaWFRfpkr jxxVCKKhzeKQKclRNp8OgbB77lxNhOxkagC6Nth116puOf/KrvzNRI0nZHBpSiEM eHvJkHzaBjQVwe2vBQuGtkj6iDvpVXa17ekcXJx1ozkZ/vEyugQRPFyAoDKUsbQc eZvNtNxJGaOuI/FHm73mn8H1vrj5J9qvM8goOSeL+0UyItmgkKFatQjTfEcMvXuv 1UJz2jbvNU370ofhgr3JEtM8jPzE5rHw6gqDBvUVWqDP2ZCuWDORFM2J9iQJ5xTC jatG9qWILCF7+b7jqZTO4blkCj77vw/mAlZhcHE4f8RCZzhogJ2TObPIVFBltdbx SpfQZ+gJyBlS8LbpK+7VSUx8pTrxKyFOtySViVUHDXmeEqa+buqic4G7UndMYgfB VGq5kIom0dZOwoVX5AoOyiiCO32zoUZhEuv3C1mkCCFb0UcDKK8QAU8e186VeT2R y7L8UconhvaA3GNJvziXJ7AlE2pmdX79yMSckzQxeDF8M1dcuMJJfps18exGlBAP uCoXo6nJ6Z8A16jxS01uaMdT0hg8uOlpThaMUNb5hEp6gcfrlXTdU8YiL9OsCDPE UIRakzgrmBJ/XTd+pETWHxly+gg/Mw2vGQtnpT5cjtA80rQCFOxxA5sEHpG8iAuC YPk/72gg3ovxMQpJKsJg =10FW -----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________ Pkg-xfce-devel mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-xfce-devel
