Package: xfce4-session
Version: 4.10.0-1
Severity: minor
Tags: upstream
Hi,
I checked xfce4-session with cppcheck and it noticed a possible leak
in xfce4-session/xfsm-legacy.c in the 4.10.0 (experimental) version.
The leak appears to be happening in an inner loop[0], but given the
name of the file (legacy) it is possibly a minor problem.
~Niels
[0] So a leak based on the number of windows ("screens" * number of
windows in that "screen").
--- xfce4-session/xfsm-legacy.c.orig 2012-11-01 11:23:53.228575912 +0100
+++ xfce4-session/xfsm-legacy.c 2012-11-01 11:28:37.624583205 +0100
@@ -306,8 +306,8 @@
SmWindow *sm_window;
int n, i;
int type;
- gchar *wmclass1;
- gchar *wmclass2;
+ gchar *wmclass1 = NULL;
+ gchar *wmclass2 = NULL;
Window root, window;
XEvent ev;
int awaiting_replies = 0;
@@ -374,6 +374,8 @@
sm_window = sm_window_new (leader, n, type, wmclass1, wmclass2);
window_list = g_list_append (window_list, sm_window);
+ g_free(wmclass2);
+ g_free(wmclass1);
}
}
_______________________________________________
Pkg-xfce-devel mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-xfce-devel
