Your message dated Tue, 21 Jan 2014 22:17:06 +0000
with message-id <[email protected]>
and subject line Bug#735478: fixed in xfce4-weather-plugin 0.7.4-5
has caused the Debian Bug report #735478,
regarding xfce4-weather-plugin: "assertion failed" on certain data from 
weather.com
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
735478: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=735478
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: xfce4-weather-plugin
Version: 0.7.4-4
Severity: important
Tags: patch

Dear Maintainer,

starting yesterday, xfce4-weather-plugin more or less often aborts due
to an assertion failure, resulting in a pop-up box from the panel
manager. Severity not set to even grave since this might happen for
certain locations only.

The actual message is:

| weather:ERROR:weather-parsers.c:304:parse_dayf: assertion failed: (ret->hi != 
NULL)

Responsible is a missing value in the data sent from weather.com:

|        <lsup>1/15/14 7:00 AM CET</lsup>
|        <day d="0" t="Wednesday" dt="Jan 15">
+        <hi></hi>
|        <low>4</low>

Dropping the assertion check from the sources however does not appear
to have negative impact, patch below.

    Christoph

-- System Information:
Debian Release: 7.3
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.10.25 (SMP w/4 CPU cores; PREEMPT)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages xfce4-weather-plugin depends on:
ii  libc6               2.13-38
ii  libcairo2           1.12.2-3
ii  libgdk-pixbuf2.0-0  2.26.1-1
ii  libglib2.0-0        2.33.12+really2.32.4-5
ii  libgtk2.0-0         2.24.10-2
ii  libpango1.0-0       1.30.0-1
ii  libxfce4util4       4.8.2-1
ii  libxfcegui4-4       4.8.1-5
ii  libxml2             2.8.0+dfsg1-7+nmu2
ii  xfce4-panel         4.8.6-4

xfce4-weather-plugin recommends no packages.

xfce4-weather-plugin suggests no packages.

-- no debconf information


commit 1cd371f498e87df3ba98a3418a6512f34b5d039b
Author: Christoph Biedl <[email protected]>
Date:   Wed Jan 15 18:08:18 2014 +0100

    Allow empty <hi></hi> in data from weather.com

diff --git a/debian/patches/99_allow_empty_hi.patch 
b/debian/patches/99_allow_empty_hi.patch
new file mode 100644
index 0000000..08e4a3c
--- /dev/null
+++ b/debian/patches/99_allow_empty_hi.patch
@@ -0,0 +1,10 @@
+--- a/panel-plugin/weather-parsers.c
++++ b/panel-plugin/weather-parsers.c
+@@ -301,7 +301,6 @@
+       if (NODE_IS_TYPE (cur_node, "hi"))
+         {
+           ret->hi = DATA (cur_node);
+-          g_assert (ret->hi != NULL);
+         }
+       else if (NODE_IS_TYPE (cur_node, "low"))
+         {
diff --git a/debian/patches/series b/debian/patches/series
index 6575a21..1e7632d 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,2 +1,3 @@
 00_license.patch
 01_uri_change.patch
+99_allow_empty_hi.patch

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message ---
Source: xfce4-weather-plugin
Source-Version: 0.7.4-5

We believe that the bug you reported is fixed in the latest version of
xfce4-weather-plugin, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Yves-Alexis Perez <[email protected]> (supplier of updated xfce4-weather-plugin 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 19 Jan 2014 21:30:22 +0100
Source: xfce4-weather-plugin
Binary: xfce4-weather-plugin
Architecture: source amd64
Version: 0.7.4-5
Distribution: wheezy
Urgency: low
Maintainer: Debian Xfce Maintainers <[email protected]>
Changed-By: Yves-Alexis Perez <[email protected]>
Description: 
 xfce4-weather-plugin - weather information plugin for the Xfce4 panel
Closes: 735478
Changes: 
 xfce4-weather-plugin (0.7.4-5) wheezy; urgency=low
 .
   * debian/patches:
     - 02_NULL-hi added, fix cases where <hi> element is empty.  closes: #735478
Checksums-Sha1: 
 2a55b2a546025c0d384e42a3720c955d74d6224c 1839 xfce4-weather-plugin_0.7.4-5.dsc
 8e435988e3829a3edea1d9cc95a92ee3d5d0b310 5395 
xfce4-weather-plugin_0.7.4-5.debian.tar.gz
 759709f45c5c8b3ab2bac2fd3addac9fe7df9785 574262 
xfce4-weather-plugin_0.7.4-5_amd64.deb
Checksums-Sha256: 
 c7c4f9d0fcf63963f7a8af15e68fc83dd436b4ca318cc6dbe3f0d6f0cd465e8e 1839 
xfce4-weather-plugin_0.7.4-5.dsc
 abf38eebd9b24a156b17a67261d16bffe2f347bc98898caa2eba36045b1cb02d 5395 
xfce4-weather-plugin_0.7.4-5.debian.tar.gz
 a330aa60233153888dc9bac0ed221df06274bc15ad12f3fa2ce52d528f5b1bf0 574262 
xfce4-weather-plugin_0.7.4-5_amd64.deb
Files: 
 a6a05b1e4362d7c96f01606d45fd2b72 1839 xfce optional 
xfce4-weather-plugin_0.7.4-5.dsc
 b621fd8864ca2fadc86c5b7904bf30b8 5395 xfce optional 
xfce4-weather-plugin_0.7.4-5.debian.tar.gz
 8796090719bfc512e0d8f96fae51c895 574262 xfce optional 
xfce4-weather-plugin_0.7.4-5_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQEcBAEBCgAGBQJS3DbHAAoJEG3bU/KmdcCl5/oH/1WuiNJkC9+szjEZkrOaoYwM
geYsHIPVsRzBVveX3phxbt0j8vevfBCCNzbBRWWMDtDfH+AtOObY6ehSJ2giIjFY
j3UwlaTIMRh6M3r4LdrdJrzOvM7C4dC+KrHhicCvCaS4PIBYvPu8GkhCt2UEwqiw
KJtd/QZl4HcuA4f/YbWh7DbaqfohEDB0pGGj6tqySj9ZOHIj1tkiCdbpqQ8YGCCA
rr8az1ne0tCAz2qgCRFhmuWfVodHEhxvVFehurHkdYl9l1ytDF4UpEtMzEmfgwqF
d2NFfq6LSxj+QSnnLprMbFixzpmUGmktsBJxAPu9aS7jcek4fj2ovbEsa7SLHRg=
=lqDq
-----END PGP SIGNATURE-----

--- End Message ---
_______________________________________________
Pkg-xfce-devel mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-xfce-devel

Reply via email to