Your message dated Sat, 18 Apr 2015 21:09:15 +0200
with message-id <[email protected]>
and subject line Re: [Pkg-xfce-devel] Bug#782844: lightdm leaks file
descriptors when using light-locker
has caused the Debian Bug report #782844,
regarding lightdm leaks file descriptors when using light-locker
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
782844: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=782844
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: lightdm
Version: 1.10.3-3
Severity: normal
Tags: patch
Dear Maintainer,
upstream bug #1190344 affects this version of lightdm. It was fixed in
upstream version 1.10.5.
It can be easily checked by the following steps:
- log in with lightdm
- check number of FIFO fds of lightdm
sudo lsof -p "pid of lighdm process" |grep FIFO | wc -l
- light-locker-command -l
- unlock session
- check number of FIFO fds of lightdm again
- number has increased by 8 in my case
This is problematic as lightdm reaches the maximum number of open file
descriptors at some point, which makes it impossible to unlock the
screen.
I have adapted the upstream patch to version 1.10.3-3 which is in unstable and
testing. It fixes the problem for me.
Cheers,
Philipp
[1] https://bugs.launchpad.net/lightdm/+bug/1190344
-- System Information:
Debian Release: 8.0
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.19.0-trunk-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages lightdm depends on:
ii adduser 3.113+nmu3
ii consolekit 0.4.6-5
ii dbus 1.8.16-1
ii debconf [debconf-2.0] 1.5.56
ii libc6 2.19-18
ii libgcrypt20 1.6.3-2
ii libglib2.0-0 2.42.1-1
ii libpam-systemd 219-6
ii libpam0g 1.1.8-3.1
ii libxcb1 1.10-3+b1
ii libxdmcp6 1:1.1.1-1+b1
ii lightdm-gtk-greeter [lightdm-greeter] 1.8.5-2
Versions of packages lightdm recommends:
ii xserver-xorg 1:7.7+7
Versions of packages lightdm suggests:
ii accountsservice 0.6.37-3+b1
ii upower 0.99.1-3.2
-- Configuration Files:
/etc/apparmor.d/lightdm-guest-session b51cea1a1248cf9bf45f2e9024c7734f [Errno
2] No such file or directory: u'/etc/apparmor.d/lightdm-guest-session
b51cea1a1248cf9bf45f2e9024c7734f'
/etc/init/lightdm.conf 956d74eee3562dd53e1c33d2025968d8 [Errno 2] No such file
or directory: u'/etc/init/lightdm.conf 956d74eee3562dd53e1c33d2025968d8'
-- debconf information:
lightdm/daemon_name: /usr/sbin/lightdm
* shared/default-x-display-manager: lightdm
diff -Nru lightdm-1.10.3/debian/changelog lightdm-1.10.3/debian/changelog
--- lightdm-1.10.3/debian/changelog 2014-11-04 21:58:17.000000000 +0100
+++ lightdm-1.10.3/debian/changelog 2015-04-18 18:45:52.000000000 +0200
@@ -1,3 +1,10 @@
+lightdm (1.10.3-3.1) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * adapt patch from LP #1190344
+
+ -- Philipp Edelmann <[email protected]> Sat, 18 Apr 2015 18:45:10 +0200
+
lightdm (1.10.3-3) unstable; urgency=medium
* debian/patches:
diff -Nru lightdm-1.10.3/debian/patches/07_fd-leak.patch lightdm-1.10.3/debian/patches/07_fd-leak.patch
--- lightdm-1.10.3/debian/patches/07_fd-leak.patch 1970-01-01 01:00:00.000000000 +0100
+++ lightdm-1.10.3/debian/patches/07_fd-leak.patch 2015-04-18 18:44:49.000000000 +0200
@@ -0,0 +1,32 @@
+--- a/src/greeter.c
++++ b/src/greeter.c
+@@ -987,12 +987,17 @@
+ g_object_unref (self->priv->authentication_session);
+ }
+ if (self->priv->to_greeter_channel)
++ {
++ close(g_io_channel_unix_get_fd(self->priv->to_greeter_channel));
+ g_io_channel_unref (self->priv->to_greeter_channel);
++ }
+ if (self->priv->from_greeter_channel)
++ {
++ close(g_io_channel_unix_get_fd(self->priv->from_greeter_channel));
+ g_io_channel_unref (self->priv->from_greeter_channel);
++ }
+ if (self->priv->from_greeter_watch)
+ g_source_remove (self->priv->from_greeter_watch);
+-
+ G_OBJECT_CLASS (greeter_parent_class)->finalize (object);
+ }
+
+--- a/src/session.c
++++ b/src/session.c
+@@ -459,6 +459,8 @@
+ if (session->priv->is_guest)
+ guest_account_cleanup (session->priv->username);
+
++ close(session->priv->to_child_input);
++ close(session->priv->from_child_output);
+ /* Drop our reference on the child process, it has terminated */
+ g_object_unref (session);
+ }
diff -Nru lightdm-1.10.3/debian/patches/series lightdm-1.10.3/debian/patches/series
--- lightdm-1.10.3/debian/patches/series 2014-10-24 14:25:50.000000000 +0200
+++ lightdm-1.10.3/debian/patches/series 2015-04-18 19:24:19.000000000 +0200
@@ -3,3 +3,4 @@
03_use-desktopnames-properties.patch
05_debianize-pam-files.patch
06_change-user-dirs.patch
+07_fd-leak.patch
--- End Message ---
--- Begin Message ---
Version: 1.12.2-1
On sam., 2015-04-18 at 19:54 +0200, Philipp Edelmann wrote:
> I have adapted the upstream patch to version 1.10.3-3 which is in unstable and
> testing. It fixes the problem for me.
At that point there's now way it'll go to Jessie 8.0. I don't think it's
really worth a stable upload for a point release, but you might want to
ask the release team about that.
I'm also marking the bug as fixed with the version in experimental.
Regards,
--
Yves-Alexis
signature.asc
Description: This is a digitally signed message part
--- End Message ---
_______________________________________________
Pkg-xfce-devel mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-xfce-devel