Your message dated Wed, 06 May 2015 22:05:44 +0000
with message-id <[email protected]>
and subject line Bug#722489: fixed in xfce4-fsguard-plugin 1.0.2-1
has caused the Debian Bug report #722489,
regarding [xfce4-fsguard-plugin] Tooltip does not handle FS <1GB size
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
722489: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=722489
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: xfce4-fsguard-plugin
Version: 1.0.1-1+b1
Severity: normal
Tags: patch

--- Please enter the report below this line. ---
I believe there is a bug in this plug-in all current Debian (including
my Wheezy) distributions which results in a tool-tip type message of
"could not check mountpoint XXX, please check your config" when the file
system that the path XXX concerns is of size less than around 1GBytes.

From inspection of the source from the latest upstream "master" from its
repository at git://git.xfce.org/panel-plugins/xfce4-fsguard-plugin I
see the problem originates there. I have formulated a patch (attached)
which I think will correct this problem.

--- System information. ---
Architecture: i386
Kernel:       Linux 3.10-0.bpo.2-rt-686-pae

Debian Release: 7.1
  500 wheezy-backports mozilla.debian.net
  500 stable-updates  mirrors.melbourne.co.uk
  500 stable          security.debian.org
  500 stable          mirrors.melbourne.co.uk
  500 stable          apt.spideroak.com
  500 release         apt.spideroak.com
  500 debs            www.duinsoft.nl
  100 wheezy-backports ftp.debian.org

--- Package information. ---
Depends                    (Version) | Installed
====================================-+-==============
libatk1.0-0              (>= 1.12.4) | 2.4.0-2
libc6                       (>= 2.4) | 2.13-38
libcairo2                 (>= 1.2.4) | 1.12.2-3
libfontconfig1            (>= 2.9.0) | 2.9.0-7.1
libfreetype6              (>= 2.2.1) | 2.4.9-1.1
libgdk-pixbuf2.0-0       (>= 2.22.0) | 2.26.1-1
libglib2.0-0             (>= 2.18.0) | 2.33.12+really2.32.4-5
libgtk2.0-0               (>= 2.8.0) | 2.24.10-2
libpango1.0-0            (>= 1.14.0) | 1.30.0-1
libxfce4ui-1-0                       | 4.8.1-1
libxfce4util4          (>= 4.3.99.2) | 4.8.2-1
xfce4-panel               (>= 4.7.7) | 4.8.6-4
xfce4-panel                 (<< 4.9) | 4.8.6-4


Package's Recommends field is empty.

Package's Suggests field is empty.



commit 7f8c65afe0d7cc658ac453a46c0f4f3bf15d7fb9
Author: Stephen Lyons <[email protected]>
Date:   Mon Sep 9 22:05:21 2013 +0100

    BugFix: Tool-tip giving wrong message for fs size < ~1GB.
    
    Signed-off-by: Stephen Lyons <[email protected]>

diff --git a/panel-plugin/fsguard.c b/panel-plugin/fsguard.c
index 8d97574..10cf6e8 100644
--- a/panel-plugin/fsguard.c
+++ b/panel-plugin/fsguard.c
@@ -291,10 +291,15 @@ fsguard_check_fs (FsGuard *fsguard)
                     (*(fsguard->name) != '\0' && strcmp(fsguard->path, 
fsguard->name)) ?
                     _("%s/%s space left on %s (%s)") : _("%s/%s space left on 
%s"),
                     msg_size, msg_total_size, fsguard->path, fsguard->name);
-    } else {
+    } else if (total > 0 ) {
         g_snprintf (msg_total_size, sizeof (msg_total_size), _("%.0f MB"), 
total);
         g_snprintf (msg_size, sizeof (msg_size), _("%.0f MB"), freespace);
         g_snprintf (msg, sizeof (msg),
+                    (*(fsguard->name) != '\0' && strcmp(fsguard->path, 
fsguard->name)) ?
+                    _("%s/%s space left on %s (%s)") : _("%s/%s space left on 
%s"),
+                    msg_size, msg_total_size, fsguard->path, fsguard->name);
+    } else {
+        g_snprintf (msg, sizeof (msg),
                     _("could not check mountpoint %s, please check your 
config"),
                     fsguard->path);
     }

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
--- Begin Message ---
Source: xfce4-fsguard-plugin
Source-Version: 1.0.2-1

We believe that the bug you reported is fixed in the latest version of
xfce4-fsguard-plugin, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Yves-Alexis Perez <[email protected]> (supplier of updated xfce4-fsguard-plugin 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 06 May 2015 21:46:51 +0200
Source: xfce4-fsguard-plugin
Binary: xfce4-fsguard-plugin
Architecture: source amd64
Version: 1.0.2-1
Distribution: unstable
Urgency: low
Maintainer: Debian Xfce Maintainers <[email protected]>
Changed-By: Yves-Alexis Perez <[email protected]>
Description:
 xfce4-fsguard-plugin - filesystem monitor plugin for the Xfce4 panel
Closes: 722489
Changes:
 xfce4-fsguard-plugin (1.0.2-1) unstable; urgency=low
 .
   [ Evgeni Golov ]
   * Correct Vcs-* URLs to point to anonscm.debian.org
 .
   [ Jackson Doak ]
   * Add 1GB-size.patch. Closes: #722489
 .
   [ Mateusz Łukasik ]
   * New upstream release.
   * Bump standards version to 3.9.6.
Checksums-Sha1:
 94cacc681abd47f9a16b945f6f917e60d418365f 1910 xfce4-fsguard-plugin_1.0.2-1.dsc
 4c87a4932b582acf4723a665cd6306c7b855e9b0 356715 
xfce4-fsguard-plugin_1.0.2.orig.tar.bz2
 8538ee37d16d37d57117e2621fe35c3992fdf430 4516 
xfce4-fsguard-plugin_1.0.2-1.debian.tar.xz
 a2666c30bd4ea66d44ad1c8ecc07c705ffbe3309 82524 
xfce4-fsguard-plugin_1.0.2-1_amd64.deb
Checksums-Sha256:
 471ec93fa82399a05d70d20d269abaf66fa5ac60ed267f45709e067a8e45c435 1910 
xfce4-fsguard-plugin_1.0.2-1.dsc
 a2c8d59386ae3d23cf6bdd06a1cdd7a1b9473cf6f38ae106600b194c601040ae 356715 
xfce4-fsguard-plugin_1.0.2.orig.tar.bz2
 e0dfce14fd97acff52a2dcb756ea992e84b2cc0bdabc6a8284fa15700e1c90a4 4516 
xfce4-fsguard-plugin_1.0.2-1.debian.tar.xz
 41014b3c3a89047eb770ab10e914645e278d257218c41d94f07de728d0f887d6 82524 
xfce4-fsguard-plugin_1.0.2-1_amd64.deb
Files:
 a3eaff75eab72e1afcb7e7c9e243bb89 1910 xfce optional 
xfce4-fsguard-plugin_1.0.2-1.dsc
 db7741d1827e428b005e94d25e2ec00a 356715 xfce optional 
xfce4-fsguard-plugin_1.0.2.orig.tar.bz2
 fec6637613dad32928798692d98820fa 4516 xfce optional 
xfce4-fsguard-plugin_1.0.2-1.debian.tar.xz
 03a3d32b42ee536008a9933afe10862c 82524 xfce optional 
xfce4-fsguard-plugin_1.0.2-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCgAGBQJVSnCSAAoJEG3bU/KmdcClWscH/iQ9sugimxVRcB4/0j0DZ9I4
/+coAwicHNDe8WOOf43iKsMHhjPlJRtDcsvQJikkYSqtO3XpEL9feuoWfmLEnuHa
DcyadQR5eYRaT5LYUzdW8JElU+9RADyfY9Nz1PUMT1UTswYqV/aIT3LMExsAal1O
rAhKQbzU4NmJU1As+MDTHWaW2zKoMQqrT9NEfEBN2rGeZIGvsA1xf5dhv7zgCPqZ
W0VKP8gEjHbeWBG1g10LJXDIW276i+lMA84u0ryncDWKnQ4JFmXNfGuCwCCd6QcR
2rRelgl1op0NEX2gBc0A1XN9mgDVtHBm4lNyw9Yh+SJ0X7iPdcdYhqorLEsQJhg=
=ebAU
-----END PGP SIGNATURE-----

--- End Message ---
_______________________________________________
Pkg-xfce-devel mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-xfce-devel

Reply via email to