Package: xfce4-xkb-plugin
Version: 1:0.7.1-2
Severity: wishlist
Tags: upstream patch

Dear Maintainer,

  I have minor issues (though it may be of personal taste) with the graphics 
layout of the xkb plugin:

1) In the text-mode layout, the current debian patch allows to select font, but 
it ignores the font size (the text is always scalled to fill the reserved 
space). This does not seems like the original intention for the size selection 
in the configuration dialog.

2) In the image-mode layout, the size of the flag is unproportionally large 
compared to other panel icon plugins.

Attached is a patch that would correct the described behaviour.

Thanks,
Pavel


-- System Information:
Debian Release: stretch/sid
  APT prefers testing-proposed-updates
  APT policy: (840, 'testing-proposed-updates'), (840, 'testing'), (740, 
'unstable'), (738, 'experimental'), (540, 'proposed-updates'), (540, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.4.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=cs_CZ.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages xfce4-xkb-plugin depends on:
ii  libc6                2.21-9
ii  libcairo2            1.14.6-1
ii  libgarcon-1-0        0.4.0-2
ii  libgdk-pixbuf2.0-0   2.32.3-1.2
ii  libglib2.0-0         2.46.2-3
ii  libgtk2.0-0          2.24.29-1
ii  libpango-1.0-0       1.38.1-1
ii  libpangocairo-1.0-0  1.38.1-1
ii  librsvg2-2           2.40.11-2
ii  libwnck22            2.30.7-5
ii  libxfce4ui-1-0       4.12.1-2
ii  libxfce4util7        4.12.1-2
ii  libxklavier16        5.2.1-1
ii  xfce4-panel          4.12.0-3

xfce4-xkb-plugin recommends no packages.

xfce4-xkb-plugin suggests no packages.

-- no debconf information
--- old/debian/patches/01-font_selection.patch	2015-03-15 22:02:34.000000000 +0100
+++ new/debian/patches/01-font_selection.patch	2016-02-25 20:09:16.723801490 +0100
@@ -144,13 +144,13 @@
 -    DBG ("txt size scale x/y: %.2f/%.2f", scalex, scaley);
 -
 -    text_height = actual_height * scaley;
-+    text_height = actual_height;
++    text_height = pango_height;
      scaley = text_height / pango_height;
      radius = (text_height < 32) ? 1.2 : 2.5;
      diameter = 2 * radius;
  
 -    text_width  = actual_width * scalex;
-+    text_width  = actual_width;
++    text_width  = pango_width;
      if (actual_width - text_width < 3 + variant_markers_count * diameter)
      {
          text_width = actual_width - 3 - (variant_markers_count) * diameter;
--- old/panel-plugin/xfce4-xkb-plugin.c	2016-02-25 22:37:50.902329409 +0100
+++ new/panel-plugin/xfce4-xkb-plugin.c	2016-02-25 23:09:12.053774427 +0100
@@ -343,6 +343,7 @@
             else
             {
                 xkb->hsize = (int) (1.33 * panel_size);
+                if ( panel_size >= 24 ) xkb->hsize = panel_size;
             }
 
             gtk_widget_set_size_request (xkb->btn, xkb->hsize, xkb->vsize);
_______________________________________________
Pkg-xfce-devel mailing list
Pkg-xfce-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-xfce-devel

Reply via email to