On 6/15/2016 7:22 PM, Fraser Tweedale wrote:
Code changes look good. Might be nice to construct the (Token|Activity)Collection objects inside the find* methods rather than constructing it at call side and passing it in to be populated. Just a nit, though.
Thanks for the suggestion. I also considered that, but the reason I decided to create the response (i.e. collection) object outside the internal find*() methods is because the internal methods are just helper methods to populate certain aspects of the response object only (i.e. the entries and the total). Suppose they do create the response object, we probably would expect that the response object would be complete. However, notice that after the internal find*() invocations we're still adding links to the response object. Also they do not perform any parameter validation either, so these methods are not meant to be called directly by anything else. To clarify the distinction I've changed them to protected retrieve*WithVLV() and retrieve*WithoutVLV(). BTW, in the future we might want to change the latter method with simple paged results.
Searching/filtering continues to work as expected. ACK.
Thanks! Pushed to master. -- Endi S. Dewata _______________________________________________ Pki-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/pki-devel
