To avoid confusion, the isSelfTestCriticalAtStartup() and isSelfTestCriticalOnDemand() in SelfTestSubsystem have been modified to no longer log an error message if the selftest being checked does not exist in the corresponding property in CS.cfg.
https://fedorahosted.org/pki/ticket/2432 Pushed to master (10.4) under one-liner/trivial rule. -- Endi S. Dewata
>From 4a6ea97f14fc2b098a6c2ec835e93e472047c6d7 Mon Sep 17 00:00:00 2001 From: "Endi S. Dewata" <[email protected]> Date: Tue, 16 Aug 2016 00:15:15 +0200 Subject: [PATCH] Removed misleading log in SelfTestSubsystem. To avoid confusion, the isSelfTestCriticalAtStartup() and isSelfTestCriticalOnDemand() in SelfTestSubsystem have been modified to no longer log an error message if the selftest being checked does not exist in the corresponding property in CS.cfg. https://fedorahosted.org/pki/ticket/2432 --- .../com/netscape/cmscore/selftests/SelfTestSubsystem.java | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/base/server/cmscore/src/com/netscape/cmscore/selftests/SelfTestSubsystem.java b/base/server/cmscore/src/com/netscape/cmscore/selftests/SelfTestSubsystem.java index ff938dd7be6f2e5ad9f70a5445b38881f5fd1813..8dc95cc5b24195759a3a0fcc9cdbc8abf06932ae 100644 --- a/base/server/cmscore/src/com/netscape/cmscore/selftests/SelfTestSubsystem.java +++ b/base/server/cmscore/src/com/netscape/cmscore/selftests/SelfTestSubsystem.java @@ -473,12 +473,7 @@ public class SelfTestSubsystem } } - // self test plugin instance property name is not present - log(mLogger, - CMS.getLogMessage( - "CMSCORE_SELFTESTS_PROPERTY_MISSING_NAME", - instanceFullName)); - + // self test undefined in selftests.container.order.onDemand throw new EMissingSelfTestException(instanceFullName); } @@ -799,12 +794,7 @@ public class SelfTestSubsystem } } - // self test plugin instance property name is not present - log(mLogger, - CMS.getLogMessage( - "CMSCORE_SELFTESTS_PROPERTY_MISSING_NAME", - instanceFullName)); - + // self test undefined in selftests.container.order.startup throw new EMissingSelfTestException(instanceFullName); } -- 2.5.5
_______________________________________________ Pki-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/pki-devel
