On 5/31/2017 6:30 PM, Matthew Harmsen wrote:
The attached patch was altered to change "args" ==> "argv" rather than "argv" ==> "args" since it was discovered that a number of the routines utilized "args" as a local variable that would have to be changed since if the "argv" input parameter were changed to "args". Consequently, this patch converts "args" ==> "argv".Please review the attached patch which addresses the following issues: * dogtagpki Pagure Issue #2713 - Build failure due to Pylint issues <https://pagure.io/dogtagpki/issue/2713> These changes were successfully compiled on a Fedora 27 machine with the following packages: * python2-2.7.13-10.fc27.x86_64 * python3-3.6.1-7.fc27.x86_64 * pylint-1.7.1-1.fc27.noarch Additionally, a CA instance was installed and configured, and the following smoke test was run: * sudo certutil -d /root/.dogtag/pki-tomcat/ca/alias -L * sudo pki -d /root/.dogtag/pki-tomcat/ca/alias -C /root/.dogtag/pki-tomcat/ca/password.conf -n "PKI Administrator for example.com" -p 8080 ca-user-add testuser --fullName "Test User" * sudo certutil -d /root/.dogtag/pki-tomcat/ca/alias -L * sudo pki -d /root/.dogtag/pki-tomcat/ca/alias -C /root/.dogtag/pki-tomcat/ca/password.conf -n "PKI Administrator for example.com" -p 8080 client-cert-request uid=testuser * sudo pki -d /root/.dogtag/pki-tomcat/ca/alias -C /root/.dogtag/pki-tomcat/ca/password.conf -n "PKI Administrator for example.com" -p 8080 ca-cert-request-review 7 --action approve * sudo pki -d /root/.dogtag/pki-tomcat/ca/alias -C /root/.dogtag/pki-tomcat/ca/password.conf -n "PKI Administrator for example.com" -p 8080 ca-user-cert-add testuser --serial 0x7 * sudo pki -d /root/.dogtag/pki-tomcat/ca/alias -C /root/.dogtag/pki-tomcat/ca/password.conf -n "PKI Administrator for example.com" -p 8080 client-cert-import testuser --serial 0x7 * sudo certutil -d /root/.dogtag/pki-tomcat/ca/alias -L
Just one thing, I was under the impression that we're supposed to remove PKIServerUpgradeScriptlet.__init__() altogether.
Christian, could you take a look a this? Everything else is good. -- Endi S. Dewata _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
