Have seen a demo of the functionality working , as well as a live
walk through of the code by cfu, highlighting the crucial parts.
Looks good, one quick thing to change.
1.
static ContentInfo getCMCBlob(SignedData signedData, byte[] data) {
Could we just put a check to make sure that one or the other of the params are
non null.
Also make sure that both are not null, which would result in a null pointer
exception at some point.
ACK with the quick fix for #1
----- Original Message -----
From: "Christina Fu" <[email protected]>
To: [email protected]
Sent: Wednesday, June 7, 2017 6:16:56 PM
Subject: [Pki-devel] [PATCH]
Ticket-2619-Allow-CA-to-process-user-signed-CMC-revo.patch
This patch is the implementation for ticket
https://pagure.io/dogtagpki/issue/2619 Allow CA to process pre-signed CMC
revocation non-signing cert requests
Patch description in patch comment area.
please review.
thanks,
Christina
_______________________________________________
Pki-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________
Pki-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/pki-devel
