On Sunday 17 August 2008, Jason Stubbs wrote: > I'm fairly happy with the state of the rewrite and so am requesting that > it be reviewed for moving into trunk/kdebase. There's not much that it > doesn't fix and not much work left to do, but no show stoppers as far as > I know.
some thoughts/comments: * i wonder if the core/ code shouldn't actually become a dataengine at some point. for now it's ok and probably good to keep it internal to the applet until we're sure about the API and structure * i think the entries (such as the author) in the .desktop file need some fixing ;). i've made some adjustments already here and will commit shortly. * the plugin name probably shouldn't be systray-refactor; it's ok for now while it's in playground, but when it moves we will want to rename it to systray and remove the old applet. i'd suggest making that change now rather than later, actually. i've made some adjustments already here and will commit shortly. * we need to start thinking about merging this widget with the notifications widget... i'm running the new tray now and the first time i started it, it showed no icons.. it's the right size, just no icons showing. the debug output shows that the FDO icons are being detected, embeded, etc: plasma(13085) SystemTray::FDO::GraphicsWidget::paint: embedding into PanelView ( 75497651 ) but nothing is actually visible =/ looks like a similar issue to Sebas perhaps, and i'll see if logging out/in helps any. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Trolltech
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
