On Friday 29 August 2008, Marco Martin wrote: > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/166/ > ----------------------------------------------------------- > > Review request for Plasma. > > > Summary > ------- > > this patch, really work in progress, adds a submenu in PanelController made > with a Plasma::Dialog containing tha aligning options and the > autohide/unerwindows options. done in a submenu because we were really at > the limit for a 1024 (iirc hig says it still have to go well in 800x600?)
yes, we're going to have to think about this. people also apparently hit the Remove button too easily and then just click through the error message *sigh* it may be a candidate for moving somewhere else as well ... it's also a bit odd that the button is called Settings when the whole thing is settings ... perhaps we could add Lock Widget in there as well, as it's probably not a button people use Every Day. > otherwise i could put 3 autoexclusive buttons "Normal" "Auto hide" and > "Panel under Windows" yes, i think that's the better idea. > Diffs > ----- > > /home/KDE/kdebase/workspace/plasma/shells/desktop/panelcontroller.h > /home/KDE/kdebase/workspace/plasma/shells/desktop/panelcontroller.cpp > /home/KDE/kdebase/workspace/plasma/shells/desktop/panelview.h > /home/KDE/kdebase/workspace/plasma/shells/desktop/panelview.cpp > > Diff: http://reviewboard.vidsolbach.de/r/166/diff diffs seem broken =/ -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Trolltech
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
