> On 2008-09-11 06:54:27, Sebastian Kügler wrote: > > /trunk/KDE/kdebase/workspace/plasma/dataengines/powermanagement/powermanagementengine.cpp, > > line 70 > > <http://reviewboard.vidsolbach.de/r/188/diff/1/?file=946#file946line70> > > > > We can return here already, as the rest of the code assume that modules > > is not empty (and reply has to be valid for this) ... or make it > > > > if (reply.isValid() && reply.value().contains("powerdevil")) { > > ... > > > > (untested, of course :P) > >
Discussed on IRC and agreed only to return when reply is not valid, included in the patch > On 2008-09-11 06:54:27, Sebastian Kügler wrote: > > /trunk/KDE/kdebase/workspace/plasma/dataengines/powermanagement/powermanagementengine.cpp, > > line 80 > > <http://reviewboard.vidsolbach.de/r/188/diff/1/?file=946#file946line80> > > > > Codingstyle, bla( "foo", ... => bla("foo", ... Fixed in the patch - Dario ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/188/#review182 ----------------------------------------------------------- On 2008-09-11 07:08:52, Dario Freddi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/188/ > ----------------------------------------------------------- > > (Updated 2008-09-11 07:08:52) > > > Review request for Plasma. > > > Summary > ------- > > As agreed on IRC with sebas, I'm porting PowerDevil engine to base > powermanagement engine. This patch adds a keyword, "PowerDevil", and 2 > sources, "currentProfile" and "availableProfiles", holding profiles data. I > needed to add a small DBus architecture to make this work. > > > Diffs > ----- > > > /trunk/KDE/kdebase/workspace/plasma/dataengines/powermanagement/powermanagementengine.h > > /trunk/KDE/kdebase/workspace/plasma/dataengines/powermanagement/powermanagementengine.cpp > > Diff: http://reviewboard.vidsolbach.de/r/188/diff > > > Testing > ------- > > Tested on my local copy, it works correctly with PowerDevil revision 859887+ > > > Thanks, > > Dario > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
