> On 2008-11-01 14:04:42, Aaron Seigo wrote: > > the PackageMetadata class is really just a wrapper around a bunch of > > QStrings. i think it makes sense to change Plasma::Package to return a > > Plasma::PackageMetadata rather than a Plasma::PackageMetadata* and add a > > copy ctor to PackageMetadata. > >
ok, the changes to Package and PackageMetadata i describe here are now done =) - Aaron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/248/#review240 ----------------------------------------------------------- On 2008-10-31 08:31:28, Petri Damstén wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/248/ > ----------------------------------------------------------- > > (Updated 2008-10-31 08:31:28) > > > Review request for Plasma. > > > Summary > ------- > > This adds support for custom package metadata. > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/libs/plasma/package.h > /trunk/KDE/kdebase/workspace/libs/plasma/package.cpp > /trunk/KDE/kdebase/workspace/libs/plasma/packagestructure.h > /trunk/KDE/kdebase/workspace/libs/plasma/packagestructure.cpp > > Diff: http://reviewboard.vidsolbach.de/r/248/diff > > > Testing > ------- > > > Thanks, > > Petri > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel