Am 16. Januar 2009 16:54 schrieb Aaron J. Seigo <ase...@kde.org>:
> On Friday 16 January 2009, Philipp Klaffert wrote:
> > Since I had some time I patched some of the minor krazy2 issues in
> > kdeplasma-addons. Mostly the QLatin1String and double-quote issues.
> > I attached the patch to this mail so feel free to look over it and if its
> > Ok, please commit it since I am not able to do so...
>
> i'm really not so much a fan of the QLatin1String changes. in these
> particular
> cases, they don't result in any useful performance improvements and they
> aren't technically incorrect, but they do impact readability. the rest of
> the
> changes look ok, however. =)
>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Qt Software
>
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
After reading your mail and considering that you are absolutely right about
that I think I let krazy be crazy about these and focus on other issues.
---
Philipp Klaffert
Index: applets/luna/phases.cpp
===================================================================
--- applets/luna/phases.cpp (Revision 911885)
+++ applets/luna/phases.cpp (Arbeitskopie)
@@ -232,7 +232,7 @@
O = torad(O);
/* all those planetary arguments, too! */
- for (i=1; i<=14; i++)
+ for (i=1; i<=14; ++i)
A[i] = torad(A[i]);
/* ok, we have all the parameters, let's apply them to the JDE.
Index: libs/conversion/volume.cpp
===================================================================
--- libs/conversion/volume.cpp (Revision 911885)
+++ libs/conversion/volume.cpp (Arbeitskopie)
@@ -146,7 +146,7 @@
QString result = unit;
result.replace("/-3", "\xb3");
result.replace("^3", "\xb3");
- result.replace("3", "\xb3");
+ result.replace('3', "\xb3");
return result;
}
Index: libs/conversion/area.cpp
===================================================================
--- libs/conversion/area.cpp (Revision 911885)
+++ libs/conversion/area.cpp (Arbeitskopie)
@@ -104,7 +104,7 @@
QString result = unit;
result.replace("/-2", "\xb2");
result.replace("^2", "\xb2");
- result.replace("2", "\xb2");
+ result.replace('2', "\xb2");
return result;
}
Index: libs/conversion/value.cpp
===================================================================
--- libs/conversion/value.cpp (Revision 911885)
+++ libs/conversion/value.cpp (Arbeitskopie)
@@ -60,7 +60,7 @@
QString Value::toString() const
{
- return d->number.toString() + " " + d->unit;
+ return d->number.toString() + ' ' + d->unit;
}
QVariant Value::number() const
Index: libs/conversion/unit.cpp
===================================================================
--- libs/conversion/unit.cpp (Revision 911885)
+++ libs/conversion/unit.cpp (Arbeitskopie)
@@ -31,4 +31,5 @@
}
-#include "unit.moc"
\ No newline at end of file
+#include "unit.moc"
+
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
