I think the functionality gained by linking against libkonq would be worth moving it to kdebase-apps. :)
- Ryan On Sat, Jan 17, 2009 at 11:16 PM, Marco Martin <[email protected]> wrote: > > >> On 2009-01-17 07:14:16, Marco Martin wrote: >> > just a quick problem i coud see > > aaah, damn review board, chewed out most of the message :) > aaanyways, the problem i see is linking against libkonq, that will break a > clean install. if this is going to be in, the runner will have to move in > kdebase/apps/plasma, alongside folderview (that's why folderview lives here) > > > - Marco > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/334/#review315 > ----------------------------------------------------------- > > > On 2009-01-17 07:02:58, Ryan Bitanga wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> http://reviewboard.vidsolbach.de/r/334/ >> ----------------------------------------------------------- >> >> (Updated 2009-01-17 07:02:58) >> >> >> Review request for Plasma. >> >> >> Summary >> ------- >> >> This is a two month old patch that I was supposed to push for 4.2 but didn't >> have the time to do so. It adds multiple action support for the nepomuk >> search runner. >> >> It makes the nepomuk runner use libkonq to retrieve actions for a selected >> match. This means that even user installed service menus can be accessed via >> KRunner. Submenus are flattened meaning that results for the open with >> actions will be all be displayed. >> >> In order to view the multiple actions, the "task-oriented" interface for >> KRunner has to be selected as the "command-oriented" interface does not >> support multiple actions. >> >> >> Diffs >> ----- >> >> >> /trunk/KDE/kdebase/workspace/plasma/runners/nepomuksearch/plasma-runner-nepomuksearch.desktop >> >> /trunk/KDE/kdebase/workspace/plasma/runners/nepomuksearch/queryclientwrapper.cpp >> /trunk/KDE/kdebase/workspace/plasma/runners/nepomuksearch/CMakeLists.txt >> >> /trunk/KDE/kdebase/workspace/plasma/runners/nepomuksearch/nepomuksearchrunner.h >> >> /trunk/KDE/kdebase/workspace/plasma/runners/nepomuksearch/nepomuksearchrunner.cpp >> >> Diff: http://reviewboard.vidsolbach.de/r/334/diff >> >> >> Testing >> ------- >> >> >> Thanks, >> >> Ryan >> >> > > _______________________________________________ > Plasma-devel mailing list > [email protected] > https://mail.kde.org/mailman/listinfo/plasma-devel > _______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
