> On 2009-03-02 12:19:07, Aaron Seigo wrote: > > code wide looks nice, and afaik is proper usage of nepomuk. > > > > build system wise ... it might be nice to make it optional rather than > > required, though. i'm ok with it being a hard requirement, but not everyone > > may appreciate that. at the very least, the check for nepomuk should happen > > in kdeplasma-addons/CMakeLists.txt and if it isn't found then the comic > > plasmoid shouldn't be build. even better would be a bit of #ifdef in the > > source code to make it truly optional (the library link line can remain; > > the nepomuk vars will just be "" in the not-there case, which is fine)
OK, I updated the diffs. Is this ok to commit? - Matthias ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/207/#review331 ----------------------------------------------------------- On 2009-03-03 05:46:26, Matthias Fuchs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/207/ > ----------------------------------------------------------- > > (Updated 2009-03-03 05:46:26) > > > Review request for Plasma. > > > Summary > ------- > > When manually saving comics (context menu) additional information is stored > using Nepomuk. > > I'm not sure if the ontologies I use are the right ones (like subject) for > what I do. Neither am I sure if the comic strip name (like XKCD) should be a > tag itself rather than only the subject. > > Please also look at the CMakeLists.txt file if I did it correctly. > > > Diffs > ----- > > /trunk/KDE/kdeplasma-addons/CMakeLists.txt 934589 > /trunk/KDE/kdeplasma-addons/applets/comic/CMakeLists.txt 934589 > /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp 934589 > /trunk/KDE/kdeplasma-addons/applets/comic/config-nepomuk.h.cmake > PRE-CREATION > > Diff: http://reviewboard.kde.org/r/207/diff > > > Testing > ------- > > Seems to work nice. > > > Thanks, > > Matthias > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
