> On 2009-03-07 09:57:34, Chani wrote: > > so... was this ever committed?
diff2 was committed in trunk #931166 - wilder ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/172/#review395 ----------------------------------------------------------- On 2009-02-24 12:15:13, wilder wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/172/ > ----------------------------------------------------------- > > (Updated 2009-02-24 12:15:13) > > > Review request for Plasma. > > > Summary > ------- > > This is an attempt to solve https://bugs.kde.org/show_bug.cgi?id=169283 > > The problem with the current implementation is that the mechanism for > blocking a run of a result of a previous query does not work, as explained in > my comment (the last one) in the br. > > The proposed way to solve this issue is to store the query term in > Plasma::QueryMatch and then check that it matches the last query before > actually running the item. A patch for kdelibs will follow. > > In this way, I believe that m_queryRunning becomes irrelevant, but I still > have to think about it for some more. > > I tried to follow all guidelines for binary compatibility in kdelibs, but > please double check that. Also I think I can add the declaration of a new > method wherever I want, but just to be sure I put them at the end. If you > confirm that their position won't matter I'll put them in a more consistent > manner. > > --J > > > This addresses bugs 169283, et and similia. > https://bugs.kde.org/show_bug.cgi?id=169283 > https://bugs.kde.org/show_bug.cgi?id=et > https://bugs.kde.org/show_bug.cgi?id=similia > > > Diffs > ----- > > > /branches/KDE/4.2/kdebase/workspace/krunner/interfaces/default/interface.cpp > 931111 > > Diff: http://reviewboard.kde.org/r/172/diff > > > Testing > ------- > > The patch appears to solve the bug. > > > Thanks, > > wilder > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
