> On 2009-03-26 10:13:09, Aaron Seigo wrote: > > trunk/KDE/kdebase/workspace/plasma/shells/desktop/checkbox.cpp, line 43 > > <http://reviewboard.kde.org/r/428/diff/1/?file=4015#file4015line43> > > > > can the pallete just be set in the ctor? or even better, just set when > > the checkbox is created? that should avoid the need for a subclass. > > wrote: > Yes, it is possible to set the palette when the checkbox is created. > However, the colour will not update when the theme is changed when in the > zoomed out mode. You would have to zoom in and then zoom out in order for the > colour to update.
set it on creation, then connect to Theme::themeChanged() and reset it in a slot. doing it on every paint seems a bit heavy handed when it can be done only when needed :) - Aaron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/428/#review628 ----------------------------------------------------------- On 2009-03-26 09:43:50, Alain Boyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/428/ > ----------------------------------------------------------- > > (Updated 2009-03-26 09:43:50) > > > Review request for Plasma. > > > Summary > ------- > > This patch adds a wrapper around QCheckBox much like the current ToolButton > wrapper. The rational is that the existing label for "Different activity for > each desktop" is always displayed in black when zoomed out and using the > Oxygen Plasma theme. With this change, the label colour now respects > Plasma::Theme::TextColor. > > Is there any reason why we are not using the Plasma::CheckBox and > Plasma::PushButton widgets here? > > > Diffs > ----- > > trunk/KDE/kdebase/workspace/plasma/shells/desktop/CMakeLists.txt 944909 > trunk/KDE/kdebase/workspace/plasma/shells/desktop/checkbox.h PRE-CREATION > trunk/KDE/kdebase/workspace/plasma/shells/desktop/checkbox.cpp PRE-CREATION > trunk/KDE/kdebase/workspace/plasma/shells/desktop/plasmaapp.cpp 944909 > > Diff: http://reviewboard.kde.org/r/428/diff > > > Testing > ------- > > Switched between the Air and Oxygen themes and the label remains visible, > switching between black and white respectively. > > > Thanks, > > Alain > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
