----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/496/#review777 -----------------------------------------------------------
Ship it! couple of comments, but generally good ... /trunk/KDE/kdebase/workspace/plasma/scriptengines/javascript/simplejavascriptapplet.h <http://reviewboard.kde.org/r/496/#comment461> maybe a good opportunity to get rid of the '2' in the name and just make it variantToScriptValue everywhere. /trunk/KDE/kdebase/workspace/plasma/scriptengines/javascript/simplejavascriptapplet.cpp <http://reviewboard.kde.org/r/496/#comment462> how about QUrl too? /trunk/KDE/kdebase/workspace/plasma/scriptengines/javascript/simplejavascriptapplet.cpp <http://reviewboard.kde.org/r/496/#comment463> this could just become a (static?) member of the class instead of having a member method that calls a file global function? - Aaron On 2009-04-01 06:51:44, Petri Damstén wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/496/ > ----------------------------------------------------------- > > (Updated 2009-04-01 06:51:44) > > > Review request for Plasma. > > > Summary > ------- > > Add support for KUrl config values. Needed e.g. if ui file has KUrlRequester. > > > Diffs > ----- > > > /trunk/KDE/kdebase/workspace/plasma/scriptengines/javascript/appletinterface.h > 947782 > > /trunk/KDE/kdebase/workspace/plasma/scriptengines/javascript/appletinterface.cpp > 947782 > > /trunk/KDE/kdebase/workspace/plasma/scriptengines/javascript/simplejavascriptapplet.h > 947782 > > /trunk/KDE/kdebase/workspace/plasma/scriptengines/javascript/simplejavascriptapplet.cpp > 947782 > > Diff: http://reviewboard.kde.org/r/496/diff > > > Testing > ------- > > > Thanks, > > Petri > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
